Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(storybook): update fast-sass-loader path #10936

Merged
merged 2 commits into from
Mar 8, 2022
Merged

chore(storybook): update fast-sass-loader path #10936

merged 2 commits into from
Mar 8, 2022

Conversation

tw15egan
Copy link
Member

@tw15egan tw15egan commented Mar 8, 2022

Fixes an issue with the v10 storybook building locally when using fast-sass-loader. This mimics the includePaths from the @carbon/react storybook config

Changelog

Changed

  • Updated the includePaths to match what we have in @carbon/react

Testing / Reviewing

Pull down locally and try and run the v10 storybook (packages/react)

@tw15egan tw15egan requested a review from a team as a code owner March 8, 2022 18:57
@netlify
Copy link

netlify bot commented Mar 8, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 0555b12

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6227b540d0523e0008e86419

😎 Browse the preview: https://deploy-preview-10936--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Mar 8, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 0555b12

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6227b54082381b00084ec2fa

😎 Browse the preview: https://deploy-preview-10936--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Mar 8, 2022 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 0555b12

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6227b540a62a4000079a11ca

😎 Browse the preview: https://deploy-preview-10936--carbon-components-react.netlify.app

@sstrubberg sstrubberg enabled auto-merge (squash) March 8, 2022 19:59
@sstrubberg sstrubberg merged commit 0a99ca1 into carbon-design-system:main Mar 8, 2022
kennylam added a commit to kennylam/carbon that referenced this pull request Jul 30, 2024
@kennylam @ariellalgilmore
fix(side-nav): update max-block-size; closes carbon-design-system#10936…
40d5cec 
… (carbon-design-system#11571)

Co-authored-by: Ariella Gilmore <ariellalgilmore@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sstrubberg sstrubberg sstrubberg approved these changes

@jnm2377 jnm2377 jnm2377 approved these changes

@joshblack joshblack Awaiting requested review from joshblack joshblack was automatically assigned from carbon-design-system/developers-system

@aledavila aledavila Awaiting requested review from aledavila aledavila was automatically assigned from carbon-design-system/developers-system

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tw15egan @sstrubberg @jnm2377