fix(react): fixed styling of med size search component #11190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Search component has some extra css styling just for md size. Which seems to make a breaking positioning for the icon. This fix removes this without affecting any other styling
|
DCO Assistant Lite bot All contributors have signed the DCO. |
|
I have read the DCO document and I hereby sign the DCO. |
|
recheck |
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
dakahn
approved these changes
Apr 12, 2022
aledavila
approved these changes
Apr 13, 2022
|
Is anything holding this PR up? |
|
@alexandertrefz Nothing holding it up, I think we just forgot to turn on auto-merge. Sorry for the delay, this should be merged shortly! |
|
@tay1orjones or @joshblack is this change released in prod yet ? if so, does it affect carbon 11? |
|
@TannerS Yeah, looks like the commit merged in was tagged with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Search component has some extra css styling just for md size.
Which seems to make a breaking positioning for the icon.
This fix removes this without affecting any other styling
Closes #11169
Closes
Found this issue but not yet reported if this issue is valid or not. But I opened up a PR to be ready with a possible fix if so.
Changelog
Removed
mdsize for theSearchcomponent. I am no sure why this styling was added as it seems to not affect anythign when removed but fix the issue at hand.Tagging @joshblack since he was on the blame for this and may have some insights!
Testing / Reviewing
Ran unit test and verified
Searchcomponent on storybook