Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(styles): add css bundles into package #11495

Merged
merged 3 commits into from
May 26, 2022
Merged

feat(styles): add css bundles into package #11495

merged 3 commits into from
May 26, 2022

Conversation

joshblack
Copy link
Contributor

Closes #11489

This PR adds in a build task which generates prebuilt CSS files in the styles package.

Changelog

New

Changed

  • Update import ordering of index.scss
  • Add build.js task and script in package.json

Removed

Testing / Reviewing

  • Pull down the PR
  • Run yarn build in packages/styles
  • Verify that css/styles.css and css/styles.min.css have been generated
  • Inspect their contents to make sure that styles are actually being generated 😅
  • Verify that css is included in the files array of package.json

@joshblack joshblack requested a review from a team as a code owner May 26, 2022 19:05
@netlify
Copy link

netlify bot commented May 26, 2022

✅ Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit 91d2fa3
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/628fcf964d38250008e326d7
😎 Deploy Preview https://deploy-preview-11495--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 26, 2022

✅ Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 91d2fa3
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/628fcf96597ce100082cf2d7
😎 Deploy Preview https://deploy-preview-11495--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 26, 2022 •
edited
Loading

✅ Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 89db5eb
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/628fe79ebcb0ab00077328d8
😎 Deploy Preview https://deploy-preview-11495--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented May 26, 2022 •
edited
Loading

✅ Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 89db5eb
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/628fe79ea5e3f90008a75ff9
😎 Deploy Preview https://deploy-preview-11495--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@theiliad
Copy link
Member

🎉 🎉 🎉

@theiliad
Copy link
Member

Thanks @joshblack for adding this!

@theiliad theiliad mentioned this pull request May 26, 2022
Merged
aledavila
aledavila approved these changes May 26, 2022
View reviewed changes
Copy link
Contributor

@aledavila aledavila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected

dakahn
dakahn approved these changes May 26, 2022
View reviewed changes
Copy link
Contributor

@dakahn dakahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked as expected 🏄🏾

@kodiakhq kodiakhq bot merged commit cd78c30 into carbon-design-system:main May 26, 2022
kennylam added a commit to kennylam/carbon that referenced this pull request Jul 30, 2024
@kennylam
chore(storybook): cwc remove stackblitz iframes from storybook (carbo…
9eb2cee 
…n-design-system#11495)

### Related Ticket(s)

carbon-design-system#15634

### Description

Removes Stackblitz iframes from Carbon web components Storybook to remove unapproved cookies.

### Changelog

**New**

- {{new thing}}

**Changed**

- {{changed thing}}

**Removed**

- Stackblitz iframes from cwc Storybook

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aledavila aledavila aledavila approved these changes

@theiliad theiliad theiliad approved these changes

@dakahn dakahn dakahn approved these changes

@jnm2377 jnm2377 Awaiting requested review from jnm2377 jnm2377 was automatically assigned from carbon-design-system/developers-system

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
Design System
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add prebuilt CSS to @carbon/styles
4 participants
@joshblack @theiliad @aledavila @dakahn