fix: remove icon from readonly text input #12382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
tay1orjones
approved these changes
Oct 25, 2022
tay1orjones
requested review from
a team and
aagonzales
and removed request for
a team
aagonzales
approved these changes
Oct 25, 2022
alisonjoseph
approved these changes
Oct 26, 2022
|
@aagonzales the standard HTML input is focusable when readonly https://www.w3schools.com/tags/tryit.asp?filename=tryhtml_input_readonly |
tw15egan
approved these changes
Oct 27, 2022
|
Hey there! v11.16.0 was just released that references this issue/PR. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #2177
Adjusts the readOnly textInput based on #2177.
Changelog
Changed
Testing / Reviewing
Reviewed the result in Storybook, updated test.