-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove icon from readonly text input #12382
fix: remove icon from readonly text input #12382
Conversation
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the changes list. But I had a follow up, is the read-only input supposed to be focusable? I see its receiving focus currently and that makes it seem like its actionable.
@aagonzales the standard HTML input is focusable when readonly https://www.w3schools.com/tags/tryit.asp?filename=tryhtml_input_readonly |
Hey there! v11.16.0 was just released that references this issue/PR. |
Contributes to #2177
Adjusts the readOnly textInput based on #2177.
Changelog
Changed
Testing / Reviewing
Reviewed the result in Storybook, updated test.