-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: readonly radio button group #12412
feat: readonly radio button group #12412
Conversation
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The visual styles look correct but the cursor interactions need to be updated:
- As-is: On hover the cursor is changing to a hand
- To-be: On hover over the icon cursor should remain an arrow and over the label text should become a type cursor. Similar to what is seen here in Checkbox.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Visually looks good, matches spec 👍
Contributes to #2177
Closes #12419
Adds the read-only feature to the RadioButtonGroup component.
Note: This does not create a read-only RadioButton as having individual buttons read-only and selected makes the others readonly.
Changelog
Added
Testing / Reviewing
Reviewed the result in Storybook and a added read-only test.