-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add read only time picker #12420
feat: add read only time picker #12420
Conversation
✅ Deploy Preview for carbon-components-react ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Visual styles are correct but cursor interactions need to be updated.
- On hover the cursor should remain as an arrow and not switch to the hand.
@aagonzales @quarryboy adjusted the cusror. One thing to note is that this leaves use with the odd situation that it is possible to select and copy the time, but not AM/PM or timezone. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Visually looks good, matches spec 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once merge conflicts are fixed
f7feb61
to
eeb62af
Compare
eeb62af
to
96fbafb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lee-chase cleaned up the merge conflicts, everything else looks great to me 👍🏻 ✅
Contributes to #2177
Closes #12409
Adds the read-only feature to the TimePicker component.
Changelog
Added
Adds readOnly property to TimePicker and functionality
Adds test for read-only TimePicker
Adds styling for read-only TimePicker.
Fixes disabled dropdowns. Could move this to a separate PR but relies upon work required for this too.
Testing / Reviewing
Reviewed the result in Storybook and a added read-only test.