-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add readonly dropdown #12430
feat: add readonly dropdown #12430
Conversation
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Looks like you have a couple merge conflicts, and one super small thing, would be nice to add
readOnly: {
control: {
type: 'boolean',
},
defaultValue: false,
},
to the Playground.argTypes in storybook
@alisonjoseph conflicts resolved The readOnly prop appears in the playground but has no default. I'm not sure adding a default value to an optional property would be correct. If anything Storybook should allow an optional property to be reset to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending design review 👍 ✅
@thyhmdo if you could review this when you have time please ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Contributes to #2177
Closes #12432
Adds the read-only feature to the Dropdown component.
Changelog
Added
Testing / Reviewing
Reviewed the result in Storybook and a added read-only test.