Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readonly MultiSelect #12435

Merged
merged 11 commits into from
Nov 8, 2022
Merged

Conversation

lee-chase
Copy link
Member

@lee-chase lee-chase commented Oct 31, 2022

Contributes to #2177

Closes #12438

Adds the read-only feature to the MultiSelect component.

Changelog

Added

  • Adds readOnly property to MultiSelect and functionality
  • Adds test for read-only MultiSelect
  • Adds styling for read-only MultiSelect.

Testing / Reviewing

Reviewed the result in Storybook and a added read-only test.

@netlify
Copy link

netlify bot commented Oct 31, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5a0cfab
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/636abe3c85d23000082fc7e2
😎 Deploy Preview https://deploy-preview-12435--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 31, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 5a0cfab
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/636abe3c5fbeac000856bd7c
😎 Deploy Preview https://deploy-preview-12435--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit on the story composition, but otherwise looks good to go!

@kodiakhq kodiakhq bot merged commit d7ffd1f into carbon-design-system:main Nov 8, 2022
@lee-chase lee-chase deleted the readonlyMultiSelect branch November 10, 2022 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Read-only inputs]: Multi-select implementation
3 participants