Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(IdPrefix): add component, docs, tests #12442

Merged
merged 11 commits into from
Nov 14, 2022

Conversation

tay1orjones
Copy link
Member

Closes #12378

Adds a new component and hook to enable consumers to prefix the autogenerated IDs placed on certain DOM elements

Changelog

New

  • add IdPrefix, related docs and tests

Testing / Reviewing

  • Ensure IdPrefix is exported
  • Ensure the new stories for IdPrefix work and make sense

@netlify
Copy link

netlify bot commented Oct 31, 2022

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit c24e1a8
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/63602bcda3814a000981dec6
😎 Deploy Preview https://deploy-preview-12442--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 31, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit c24e1a8
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/63602bcd6764b10008cd17eb
😎 Deploy Preview https://deploy-preview-12442--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 31, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a138219
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/6372a16b8e2b380008a3a481
😎 Deploy Preview https://deploy-preview-12442--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 31, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit a138219
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6372a16b71c03c0009ef3a60
😎 Deploy Preview https://deploy-preview-12442--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tay1orjones tay1orjones requested a review from a team as a code owner October 31, 2022 20:33
@alisonjoseph
Copy link
Member

I'm not seeing this in storybook? 👀

@tay1orjones
Copy link
Member Author

@alisonjoseph whoops - forgot to push up some changes 😅 Should be fixed now!

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, do we need to index this for Platform?

@tay1orjones
Copy link
Member Author

This LGTM, do we need to index this for Platform?

@alisonjoseph We could, but we currently don't index it's sibling component/hook ClassPrefix, or usePrefix.

@kodiakhq kodiakhq bot merged commit 133d294 into carbon-design-system:main Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: Duplicate ids between AccordionItem and Footer
3 participants