test(Slider): add additional RTL tests #12767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
tay1orjones
reviewed
Dec 5, 2022
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
tw15egan
reviewed
Dec 7, 2022
…on into 12676-slider-rtl-tests
matthewgallo
requested review from
tay1orjones and
tw15egan
and removed request for
aledavila and
tay1orjones
tw15egan
approved these changes
Dec 7, 2022
tay1orjones
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12676
This PR adds RTL tests, building upon the
readOnlytests that Lee started, for the Slider component.I ran into an issue/may have potentially found a bug while testing the
onInputKeyUpprop, receiving an error sayingUnknown event handler property 'onInputKeyUp'. It will be ignored.I got this error message when testing this component within the Carbon repo and also adding this prop in a sandbox environment (using latest@carbon/reactrelease). Because of this I've left out the test for that prop.Changelog
Changed
Slider-test.jsRemoved
Slider/__test__/Slider-test.js(moved this intoSlider/Slider-test.js)Testing / Reviewing
Ran all tests locally
