Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(style): add forward ref docs #12775

Merged

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented Dec 5, 2022

This adds some brief thoughts on our usage of forwarded refs to our coding style guide. Based on feedback from @janhassel.

Changelog

Changed

  • Add new section to docs/style.md

@tay1orjones tay1orjones requested a review from a team as a code owner December 5, 2022 14:49
@tay1orjones tay1orjones self-assigned this Dec 5, 2022
@tay1orjones tay1orjones added this to the 2022 Q4 milestone Dec 5, 2022
@netlify
Copy link

netlify bot commented Dec 5, 2022

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2df0f10
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/638f7faaf2b1de0008f991bc
😎 Deploy Preview https://deploy-preview-12775--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Dec 5, 2022

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 2df0f10
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/638f7faa122fa400088cfdb2
😎 Deploy Preview https://deploy-preview-12775--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@kodiakhq kodiakhq bot merged commit 87ca016 into carbon-design-system:main Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants