fix(structured-list): add selected background border #13384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
francinelucca
added
status: one more review 👀
and removed
status: ready for review 👀
labels
|
Any idea what this little border variance is? It is on
|
tw15egan
approved these changes
Mar 22, 2023
laurenmrice
requested changes
Mar 24, 2023
|
Re-requesting reviews @tw15egan @laurenmrice @francinelucca This PR now should have correct hover and border colors, it should hide the border when on hover/selected and it should fix the border bug from #13383 |
|
@alisonjoseph the fix looks great! But I'm able to click and change the background on the default |
…oseph/carbon into selected-structured-list
|
@tw15egan good catch! Should be fixed now 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5232
Closes #13383
Changelog
Adds selected background state for structured list. Noticed a bug with the border while adding this and created a new issue.
New
Testing / Reviewing
Check that selected state is correct
https://deploy-preview-13384--carbon-components-react.netlify.app/?path=/story/components-structuredlist--selection
Thanks @francinelucca for the cross-browser fix! 🥳