Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ActionableNotification): fix padding issue with button #13971

Merged

Conversation

tw15egan
Copy link
Member

@tw15egan tw15egan commented Jun 12, 2023

Closes #13969

Adjusts padding so it does not 0 out the top/bottom padding values

Changelog

Changed

  • Changed padding to padding-left and padding-right

Testing / Reviewing

Ensure ActionableNotification looks correct

@netlify
Copy link

netlify bot commented Jun 12, 2023

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a9db915
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64885da39d4b98000806093b
😎 Deploy Preview https://deploy-preview-13971--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 12, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit a9db915
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64885da395f28500085f0229
😎 Deploy Preview https://deploy-preview-13971--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kodiakhq kodiakhq bot merged commit dab66af into carbon-design-system:main Jun 13, 2023
francinelucca pushed a commit to francinelucca/carbon that referenced this pull request Jun 13, 2023
…sign-system#13971)

Co-authored-by: Guilherme Datilio Ribeiro <guilhermedatilio@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: ActionableNotifications has incorrect padding on actions button
3 participants