Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(uishell): add complex states avt coverage and keyboard navigation tests #14045

Merged

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented Jun 20, 2023

Part of #13747

Thanks for pairing up on this @andreancardona!

Changelog

New

  • Broke @avt tests out into their own UIShell-test.avt.e2e.js file
    • @vrt tests remain in the UIShell-test.e2e.js file
    • One side benefit of this approach to break tests out into separate files is that these can be spread out across many workers in CI. This should help avoid any increases to the time it takes to complete the e2e test suite as we add these additional tests across many components.
  • Added new tests for complex/problematic states
  • Added a new test for keyboard navigation of UIShell

Changed

  • Update playwright config glob to match and include the new test file naming structure (avt.e2e.js)

Testing / Reviewing

  • CI should pass
  • Ensure the tests pass a sniff test and don't look problematic

@netlify
Copy link

netlify bot commented Jun 20, 2023

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 35d0441
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/649992a031575b00089749a5
😎 Deploy Preview https://deploy-preview-14045--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Jun 20, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 35d0441
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/649992a0d8f6aa0008599b69
😎 Deploy Preview https://deploy-preview-14045--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! The tests are passing

@kodiakhq kodiakhq bot merged commit 3b06b82 into carbon-design-system:main Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants