Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(TextInput): add AVT testing for disabled state #14148

Conversation

francinelucca
Copy link
Collaborator

@francinelucca francinelucca commented Jul 6, 2023

Closes #14122

Changelog

New

  • Broke @AVT tests out into their own TextInput-test.avt.e2e.js file
  • @vrt tests remain in the TextInput-test.e2e.js file
  • Added avt testing for disabled state
  • Modified visitStory function to allow for controls

Testing / Reviewing

  • CI should pass
  • Ensure the tests pass a sniff test and don't look problematic

@netlify
Copy link

netlify bot commented Jul 6, 2023

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a21172d
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64b00615d0d9e80008f32d48
😎 Deploy Preview https://deploy-preview-14148--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 6, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit a21172d
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64b0061553e3a6000855fa48
😎 Deploy Preview https://deploy-preview-14148--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodiakhq kodiakhq bot merged commit 7f623ee into carbon-design-system:main Jul 13, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add AVT coverage for TextInput states: Disabled
3 participants