test(Multiselect): add AVT for multiselect #14305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tay1orjones
approved these changes
Jul 25, 2023
alisonjoseph
approved these changes
Jul 25, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Merged
via the queue into
carbon-design-system:main
with commit Jul 25, 2023
96b874c
16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14210
Closes #14215
Refs #14276
Adds in AVT for
MultiselectandFilterableMultiselect. This would be nice to get in to ensure functionality remains the same during the Downshift upgrade (#14276). These tests add a11y checks when the menu is closed; open currently has errors, so under askipflag for now. It also tests all keyboard navigation such as opening/closing, making a selection, and clearing a selection.Changelog
New
Multiselect,FilterableMultiselectMultiselect,FilterableMultiselectChanged
ariaLabelandaria-labelas deprecated inFilterableMultiselect. These were causing a11y violations.Removed
avttests fromvrtfilearia-labelfromListBoxinsideFilterableMultiselect. This was causing an a11y violation.aria-labelTesting / Reviewing
Ensure the
avttest file covers all intended usage