-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(Multiselect): add AVT for multiselect #14305
Conversation
✅ Deploy Preview for carbon-components-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those keyboard nav test blocks are beefy! 💪
Looks great, thanks for putting this together. I agree it'll be good to track the same coverage as we review the downshift upgrade PR
96b874c
Closes #14210
Closes #14215
Refs #14276
Adds in AVT for
Multiselect
andFilterableMultiselect
. This would be nice to get in to ensure functionality remains the same during the Downshift upgrade (#14276). These tests add a11y checks when the menu is closed; open currently has errors, so under askip
flag for now. It also tests all keyboard navigation such as opening/closing, making a selection, and clearing a selection.Changelog
New
Multiselect
,FilterableMultiselect
Multiselect
,FilterableMultiselect
Changed
ariaLabel
andaria-label
as deprecated inFilterableMultiselect
. These were causing a11y violations.Removed
avt
tests fromvrt
filearia-label
fromListBox
insideFilterableMultiselect
. This was causing an a11y violation.aria-label
Testing / Reviewing
Ensure the
avt
test file covers all intended usage