fix: backport v10 aria-describedby to components with helperText #14433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisonjoseph
requested review from
tay1orjones and
guidari
and removed request for
a team
alisonjoseph
changed the title
alisonjoseph
added
version: 10
tay1orjones
approved these changes
Aug 14, 2023
guidari
added
status: ready to merge 🎉
status: enable automerge 🟠
and removed
status: one more review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14407
Backport #13371 to v10
Changelog
Changed
Changed
aria-describedbyattribute inMultiselect,Dropdown,Combobox,DatePickerInput,NumberInput,Select,ProgressBar,TextArea,ControlledPasswordInput,PasswordInputTesting / Reviewing
Ensure nothing is broken and aria-described-by is rendering for all components