Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: test github action bot #14491

Conversation

andreancardona
Copy link
Contributor

@andreancardona andreancardona commented Aug 22, 2023

Part of #14294

This is to test the github bot - this is just the second of a series of tests

Worked on this with @garrigoose 🎉

MERGING for testing purposes

@netlify
Copy link

netlify bot commented Aug 22, 2023

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit 874d7ba
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64e4d61b30263c000996dbed
😎 Deploy Preview https://deploy-preview-14491--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 22, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 874d7ba
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64e4d61baa734d0008be6912
😎 Deploy Preview https://deploy-preview-14491--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 22, 2023

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit c64449d
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64e8b95c7a47d900088a8ccd
😎 Deploy Preview https://deploy-preview-14491--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 22, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit c64449d
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64e8b95c9a6db5000829ee56
😎 Deploy Preview https://deploy-preview-14491--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty solid! Just a couple minor thoughts, these apply to both workflows

add-comment:
## TODO: figure out how to escape colons for labels
# if: github.event.label.name == "proposal: accepted" && github.event.label.name == "community contribution"
if: "${{ contains(github.event.label, 'proposal: accepted') && contains(github.event.label, 'communit contribution') }}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went down a big rabbit hole last month with finding valid yaml syntax that allows colons. What I discovered was we need to use format() on the label name. Like this:

contains(github.event.labels.*.name, format('proposal{0} accepted', ':'))

This replaces the first parameter's {0} with the value of the second parameter :

Here's how it looks in what I delivered:

if:
${{ contains(github.event.pull_request.labels.*.name,
format('status{0} ready to merge 🎉', ':')) ||
contains(github.event.pull_request.labels.*.name, format('status{0}
enable automerge 🟠', ':'))}}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was down that same rabbit hole this morning while working on this with Andrea. Is this a better way than the escape syntax below? It was not throwing any errors in the ide.

"${{ contains(github.event.label, 'proposal: accepted') && contains(github.event.label, 'community contribution') }}"

Copy link
Member

@tay1orjones tay1orjones Aug 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@garrikats Yeah I tried it in this commit: 66004ba, and it still didn't work 😕

Using format() was the only thing I found that worked. It's a shame because I think it's terrible for readability.

.github/workflows/contribution-approved.yml Outdated Show resolved Hide resolved
@tay1orjones tay1orjones added role: dev 🤖 type: infrastructure 🤖 Issues relating to devops, tech debt, etc. labels Aug 24, 2023
andreancardona and others added 2 commits August 25, 2023 07:21
Co-authored-by: Taylor Jones <tay1orjones@users.noreply.github.com>
@andreancardona andreancardona merged commit 639c29c into carbon-design-system:main Aug 25, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: dev 🤖 type: infrastructure 🤖 Issues relating to devops, tech debt, etc.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants