Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(UI icons): update 2023-09 #14558

Merged
merged 3 commits into from
Sep 6, 2023

Conversation

LMapes
Copy link
Contributor

@LMapes LMapes commented Aug 31, 2023

Changed

  • {{updated friendly names and aliases}}

update friendly names
@LMapes LMapes requested a review from a team as a code owner August 31, 2023 22:57
@LMapes
Copy link
Contributor Author

LMapes commented Sep 1, 2023

@tw15egan Need to edit this PR if possible. Don't know how to do that at this point without creating a whole new PR.

Would like to change two friendly names:
IBM® Power® VS Private Cloud
changes to
IBM® Power® Virtual Server Private Cloud

IBM Cloud® VPC
changes to
IBM Cloud® Virtual Private Cloud

@netlify
Copy link

netlify bot commented Sep 1, 2023

Deploy Preview for carbon-components-react ready!

Name Link
🔨 Latest commit 0924c6d
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/64f1d74992c561000876d2ec
😎 Deploy Preview https://deploy-preview-14558--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 1, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 0924c6d
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/64f1d74917e58f00071c24ac
😎 Deploy Preview https://deploy-preview-14558--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tw15egan
Copy link
Member

tw15egan commented Sep 1, 2023

@LMapes I've made the changes you requested, let me know if anything else needs to be updated 👍🏻

@LMapes
Copy link
Contributor Author

LMapes commented Sep 1, 2023

@tw15egan all good to go!

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @tw15egan!

@github-actions github-actions bot added this pull request to the merge queue Sep 6, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 6, 2023
@tw15egan tw15egan added this pull request to the merge queue Sep 6, 2023
Merged via the queue into carbon-design-system:main with commit 0bca370 Sep 6, 2023
15 checks passed
misiekhardcore pushed a commit to misiekhardcore/carbon that referenced this pull request Sep 18, 2023
* feat(UI icons): update 2023-09

update friendly names

* fix(Icons): update friendly name, fix error

---------

Co-authored-by: TJ Egan <tw15egan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants