-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(menuButton): fix RTL issues with MenuButton #14565
Merged
tw15egan
merged 6 commits into
carbon-design-system:logical-properties
from
tw15egan:rtl-menubutton
Sep 5, 2023
Merged
fix(menuButton): fix RTL issues with MenuButton #14565
tw15egan
merged 6 commits into
carbon-design-system:logical-properties
from
tw15egan:rtl-menubutton
Sep 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tw15egan
requested review from
andreancardona and
guidari
and removed request for
a team
September 1, 2023 14:46
tw15egan
force-pushed
the
rtl-menubutton
branch
from
September 1, 2023 16:50
ce76505
to
c78cea5
Compare
All issues should be fixed with |
tay1orjones
approved these changes
Sep 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one minor thought
tay1orjones
approved these changes
Sep 5, 2023
tw15egan
merged commit Sep 5, 2023
6ec1cda
into
carbon-design-system:logical-properties
1 check passed
15 tasks
tw15egan
added a commit
that referenced
this pull request
Sep 5, 2023
* fix(menuButton): fix RTL issues with MenuButton * fix(Menu): adjust caret rotation * refactor(menu): remove rtl override * fix(Menu): adjust story positioning, add CaretLeft for RTL mode * refactor(Menu): useLayoutContext to check if parent has direction set
tw15egan
added a commit
that referenced
this pull request
Sep 11, 2023
* fix(menuButton): fix RTL issues with MenuButton * fix(Menu): adjust caret rotation * refactor(menu): remove rtl override * fix(Menu): adjust story positioning, add CaretLeft for RTL mode * refactor(Menu): useLayoutContext to check if parent has direction set
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 11, 2023
…upport (#14580) * refactor(@carbon/styles): use logical properties for better RTL support (#14531) * refactor(styles): update styles to use CSS logical properties * fix(styles): change padding-inline-end to padding-inline * fix(styles): run stylelint --fix on components * fix(styles): run stylelint --fix on utilities * fix(Select): test padding fix * chore(stylelint): run styelint on files outside @carbon/styles * fix(AspectRatio): remove unsupported float: inline-start * fix(ContainedList): redefine tag tokens in contained list * fix(ContainedList): keep story the same * [WIP] fix(components): fix RTL issues with components (#14546) * fix(components): fix RTL issues with components * style(components): more fixes for RTL styles * style(components): more fixes for RTL styles * fix(Popover): fix popover styles in RTL mode * fix(TreeView): fix RTL issues with TreeView * fix(Breadcrumb): fix small issue with overflow menu variant * fix(Popover): fix autoalign story issues * fix(menuButton): fix RTL issues with MenuButton (#14565) * fix(menuButton): fix RTL issues with MenuButton * fix(Menu): adjust caret rotation * refactor(menu): remove rtl override * fix(Menu): adjust story positioning, add CaretLeft for RTL mode * refactor(Menu): useLayoutContext to check if parent has direction set * style(React): fix linting issues with storybook styles * test(Accordion): update snapshots * fix(Tooltip): move border
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 12, 2023
* refactor(@carbon/styles): use logical properties for better RTL support (#14531) * refactor(styles): update styles to use CSS logical properties * fix(styles): change padding-inline-end to padding-inline * fix(styles): run stylelint --fix on components * fix(styles): run stylelint --fix on utilities * fix(Select): test padding fix * chore(stylelint): run styelint on files outside @carbon/styles * fix(AspectRatio): remove unsupported float: inline-start * fix(ContainedList): redefine tag tokens in contained list * fix(ContainedList): keep story the same * [WIP] fix(components): fix RTL issues with components (#14546) * fix(components): fix RTL issues with components * style(components): more fixes for RTL styles * style(components): more fixes for RTL styles * fix(Popover): fix popover styles in RTL mode * fix(TreeView): fix RTL issues with TreeView * fix(Breadcrumb): fix small issue with overflow menu variant * fix(Popover): fix autoalign story issues * fix(menuButton): fix RTL issues with MenuButton (#14565) * fix(menuButton): fix RTL issues with MenuButton * fix(Menu): adjust caret rotation * refactor(menu): remove rtl override * fix(Menu): adjust story positioning, add CaretLeft for RTL mode * refactor(Menu): useLayoutContext to check if parent has direction set * style(React): fix linting issues with storybook styles * test(Accordion): update snapshots * fix(Tooltip): move border * fix(components): fix a few more RTL issues with components * fix(Slider): adjust positioning logic when rtl mode is enabled * chore(test): remove console.log * test(Slider): update tests * fix(ProgressBar): reverse indeterminate animation in RTL mode
misiekhardcore
pushed a commit
to misiekhardcore/carbon
that referenced
this pull request
Sep 18, 2023
…upport (carbon-design-system#14580) * refactor(@carbon/styles): use logical properties for better RTL support (carbon-design-system#14531) * refactor(styles): update styles to use CSS logical properties * fix(styles): change padding-inline-end to padding-inline * fix(styles): run stylelint --fix on components * fix(styles): run stylelint --fix on utilities * fix(Select): test padding fix * chore(stylelint): run styelint on files outside @carbon/styles * fix(AspectRatio): remove unsupported float: inline-start * fix(ContainedList): redefine tag tokens in contained list * fix(ContainedList): keep story the same * [WIP] fix(components): fix RTL issues with components (carbon-design-system#14546) * fix(components): fix RTL issues with components * style(components): more fixes for RTL styles * style(components): more fixes for RTL styles * fix(Popover): fix popover styles in RTL mode * fix(TreeView): fix RTL issues with TreeView * fix(Breadcrumb): fix small issue with overflow menu variant * fix(Popover): fix autoalign story issues * fix(menuButton): fix RTL issues with MenuButton (carbon-design-system#14565) * fix(menuButton): fix RTL issues with MenuButton * fix(Menu): adjust caret rotation * refactor(menu): remove rtl override * fix(Menu): adjust story positioning, add CaretLeft for RTL mode * refactor(Menu): useLayoutContext to check if parent has direction set * style(React): fix linting issues with storybook styles * test(Accordion): update snapshots * fix(Tooltip): move border
misiekhardcore
pushed a commit
to misiekhardcore/carbon
that referenced
this pull request
Sep 18, 2023
…em#14635) * refactor(@carbon/styles): use logical properties for better RTL support (carbon-design-system#14531) * refactor(styles): update styles to use CSS logical properties * fix(styles): change padding-inline-end to padding-inline * fix(styles): run stylelint --fix on components * fix(styles): run stylelint --fix on utilities * fix(Select): test padding fix * chore(stylelint): run styelint on files outside @carbon/styles * fix(AspectRatio): remove unsupported float: inline-start * fix(ContainedList): redefine tag tokens in contained list * fix(ContainedList): keep story the same * [WIP] fix(components): fix RTL issues with components (carbon-design-system#14546) * fix(components): fix RTL issues with components * style(components): more fixes for RTL styles * style(components): more fixes for RTL styles * fix(Popover): fix popover styles in RTL mode * fix(TreeView): fix RTL issues with TreeView * fix(Breadcrumb): fix small issue with overflow menu variant * fix(Popover): fix autoalign story issues * fix(menuButton): fix RTL issues with MenuButton (carbon-design-system#14565) * fix(menuButton): fix RTL issues with MenuButton * fix(Menu): adjust caret rotation * refactor(menu): remove rtl override * fix(Menu): adjust story positioning, add CaretLeft for RTL mode * refactor(Menu): useLayoutContext to check if parent has direction set * style(React): fix linting issues with storybook styles * test(Accordion): update snapshots * fix(Tooltip): move border * fix(components): fix a few more RTL issues with components * fix(Slider): adjust positioning logic when rtl mode is enabled * chore(test): remove console.log * test(Slider): update tests * fix(ProgressBar): reverse indeterminate animation in RTL mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some positioning logic inside
Menu
andMenuButton
.Changelog
Changed
RTL
Testing / Reviewing
Check
Menu
andMenuButton
stories in both LTR and RTL modes. Should render as expected.One note: I'm seeing an issue where the state seems to be stale if you go from
MenuButton
toMenu
with RTL enabled. It appears on the wrong side. However, once you refresh it is fixed. Any ideas? Can probably be fixed later