Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add TypeScript types for ErrorBoundary and ErrorBoundaryContext #15348

Merged
merged 4 commits into from
Dec 19, 2023

Conversation

Tresau
Copy link
Contributor

@Tresau Tresau commented Dec 7, 2023

Closes #13552

Adds TypeScript types to ErrorBoundary and ErrorBoundaryContext components

Changelog

New

  • types for ErrorBoundary and ErrorBoundaryContext

Changed

  • .js extenstions -> .ts and .tsx

Removed

  • N/A

Testing / Reviewing

Verify that unit test run and pass
Verify that Storybook components work as intended

@Tresau Tresau requested a review from a team as a code owner December 7, 2023 16:15
Copy link

netlify bot commented Dec 7, 2023

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7fd0563
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6578688ccbe62c00088233ed
😎 Deploy Preview https://deploy-preview-15348--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Tresau Tresau force-pushed the type-error-boundary branch from a957739 to 49c2d00 Compare December 7, 2023 16:22
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tw15egan tw15egan added this pull request to the merge queue Dec 19, 2023
Merged via the queue into carbon-design-system:main with commit a0fd477 Dec 19, 2023
20 checks passed
danoro96 pushed a commit to danoro96/carbon that referenced this pull request Jan 18, 2024
…carbon-design-system#15348)

Co-authored-by: Taylor Jones <tay1orjones@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add TypeScript types to ErrorBoundary, ErrorBoundaryContext
3 participants