fix: modified _number-input.scss:91 #15421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DCO Assistant Lite bot All contributors have signed the DCO. |
|
I have read the DCO document and I hereby sign the DCO. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
tw15egan
requested changes
Dec 19, 2023
packages/styles/scss/components/number-input/_number-input.scss
Outdated
Show resolved
Hide resolved
dev-ghostly
force-pushed
the
issue15414
branch
from
d5ea97a to
ab8196b
Compare
tw15egan
approved these changes
Dec 19, 2023
dev-ghostly
force-pushed
the
issue15414
branch
from
ae42b99 to
6e4e3c0
Compare
guidari
approved these changes
Dec 27, 2023
Merged
via the queue into
carbon-design-system:main
with commit Dec 27, 2023
0382e35
22 checks passed
danoro96
pushed a commit
to danoro96/carbon
that referenced
this pull request
Jan 18, 2024
* fix: modified _number-input.scss:91 * fix: put back to 128px * fix: adjust padding on invalid state * fix: put back 128px
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15414
Fixes an issue with padding when
hideSteppersis set to trueChangelog
New
Changed
Removed
Testing / Reviewing
{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}
Full report :
The input was like this before
Right now it will be like this :
Changes did on styles/scss/components/number-input/_number-input.scss:91
Please note that it seems that the bug appeared only with invalid property and container under 150px and that the natural min-width of the NumberInput is 150px, which mean that you will have bug under that container size.
Edit : Problem, I actually modified no JS code, but 2 failed tests are blocking me