Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react): added onClick type to SwitcherItem #15457

Merged
merged 3 commits into from
Jan 8, 2024
Merged

fix(react): added onClick type to SwitcherItem #15457

merged 3 commits into from
Jan 8, 2024

Conversation

amercury
Copy link
Contributor

@amercury amercury commented Jan 2, 2024 •
edited
Loading

Closes #15440

added a type for onClick handler in SwitcherItem component

Changelog

New

  • onClick prop in SwitcherItem component

Changed

  • SwitcherItem.tsx, SwitcherItem-test.js

Removed

Testing / Reviewing

@amercury amercury requested review from a team as code owners January 2, 2024 11:59
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2024 •
edited
Loading

DCO Assistant Lite bot All contributors have signed the DCO.

@netlify Netlify
Copy link

netlify bot commented Jan 2, 2024 •
edited
Loading

✅ Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0a23eeb
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/659bff661218440008da8425
😎 Deploy Preview https://deploy-preview-15457--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

andreancardona
andreancardona approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! @amercury looks good. You just need to add the following comment "I have read the DCO document and I hereby sign the DCO."

@amercury
Copy link
Contributor Author

amercury commented Jan 3, 2024

I have read the DCO document and I hereby sign the DCO.

@amercury
Copy link
Contributor Author

amercury commented Jan 3, 2024

recheck

@github-actions github-actions bot added this pull request to the merge queue Jan 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 3, 2024
@amercury amercury force-pushed the fix-switcheritem-add-typing-for-onclick branch 2 times, most recently from 6363d06 to e1ccc44 Compare January 4, 2024 10:39
@amercury amercury force-pushed the fix-switcheritem-add-typing-for-onclick branch from e1ccc44 to e7f7763 Compare January 4, 2024 11:10
@amercury
Copy link
Contributor Author

amercury commented Jan 4, 2024

recheck

@amercury
Copy link
Contributor Author

amercury commented Jan 8, 2024

@andreancardona @guidari sorry to bother you, but what can I do to run a pipeline with checks like avt, format, lint etc. to merge my branch with master?

@guidari guidari added this pull request to the merge queue Jan 8, 2024
@guidari
Copy link
Contributor

guidari commented Jan 8, 2024

@andreancardona @guidari sorry to bother you, but what can I do to run a pipeline with checks like avt, format, lint etc. to merge my branch with master?

Hey @amercury
The branch is on merge queue and it will merge soon!
Thank you for the contribution! 🚀

Merged via the queue into carbon-design-system:main with commit 384f35b Jan 8, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreancardona andreancardona andreancardona approved these changes

@guidari guidari guidari approved these changes

@tw15egan tw15egan Awaiting requested review from tw15egan tw15egan was automatically assigned from carbon-design-system/developers-system

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: SwitcherItem types. "onClick" prop does not exist
3 participants
@amercury @guidari @andreancardona