Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deprecated ContainedList.ContainedListItem #16552

Merged
merged 1 commit into from
May 23, 2024
Merged

fix: deprecated ContainedList.ContainedListItem #16552

merged 1 commit into from
May 23, 2024

Conversation

Gururajj77
Copy link
Contributor

Closes First task of #16354

Deprecates ContainedList.ContainedListItem usage

Changelog

Changed

  • used DeprecateFieldOnObject to mark the usage of ContainedList.ContainedListItem as deprecated
  • Added the test mock for DeprecateFieldOnObject

Testing / Reviewing

Please add an item as ContainedList.ContainedListItem and see the warning in the console

@Gururajj77 Gururajj77 requested a review from a team as a code owner May 23, 2024 12:21
@netlify Netlify
Copy link

netlify bot commented May 23, 2024

✅ Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5e1ec04
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/664f34dd512d3a000716d376
😎 Deploy Preview https://deploy-preview-16552--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented May 23, 2024

✅ Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 5e1ec04
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/664f34dd4e92990008833301
😎 Deploy Preview https://deploy-preview-16552--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Gururajj77 Gururajj77 mentioned this pull request May 23, 2024
Closed
tay1orjones
tay1orjones approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

riddhybansal
riddhybansal approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@riddhybansal riddhybansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@riddhybansal riddhybansal added this pull request to the merge queue May 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 23, 2024
@Gururajj77 Gururajj77 added this pull request to the merge queue May 23, 2024
Merged via the queue into carbon-design-system:main with commit e048761 May 23, 2024
21 checks passed
@Gururajj77 Gururajj77 deleted the deprecate-contained-list branch May 23, 2024 15:27
@bcgov-devops bcgov-devops mentioned this pull request Jun 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tay1orjones tay1orjones tay1orjones approved these changes

@riddhybansal riddhybansal riddhybansal approved these changes

@guidari guidari Awaiting requested review from guidari guidari is a code owner automatically assigned from carbon-design-system/developers-system-reviewers

Assignees
No one assigned
Labels
status: one more review 👀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gururajj77 @tay1orjones @riddhybansal