-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(floating-ui): add feature flag for dynamic floating-ui styles #17727
feat(floating-ui): add feature flag for dynamic floating-ui styles #17727
Conversation
Co-authored-by: kennylam <909118+kennylam@users.noreply.github.com>
…g.mdx Co-authored-by: Taylor Jones <tay1orjones@users.noreply.github.com>
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17727 +/- ##
==========================================
- Coverage 79.00% 78.99% -0.01%
==========================================
Files 408 408
Lines 14009 14032 +23
Branches 4320 4338 +18
==========================================
+ Hits 11068 11085 +17
- Misses 2775 2782 +7
+ Partials 166 165 -1 ☔ View full report in Codecov by Sentry. |
4b4fe02
Closes #17018
This PR introduces a new feature flag (
enable-v12-dynamic-floating-styles
) to separate the@floating-ui
logic. By turning on the flag, components will have dynamically positioned floating styles without the collision detection currently in place.To have the collision detect logic, adopter will set the
autoAlign
prop to true which will automatically include the dynamic styling - so the feature flag is not necessary in this case.Changelog
New
enable-v12-dynamic-floating-styles
feature flagChanged
@floating-ui
to separate out the style and middleware logicTesting / Reviewing
Feature flags
sectionDynamic floating styles
folder and inspect the components and see that the styles are set dynamically