-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Dropdown): remove extra space at the end #17751
fix(Dropdown): remove extra space at the end #17751
Conversation
All contributors have signed the DCO. |
I have read the DCO document and I hereby sign the DCO. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
82fd126
to
6760d96
Compare
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17751 +/- ##
==========================================
+ Coverage 79.33% 80.19% +0.86%
==========================================
Files 406 406
Lines 14019 14040 +21
Branches 4388 4399 +11
==========================================
+ Hits 11122 11260 +138
+ Misses 2731 2613 -118
- Partials 166 167 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks the error and warning states for the component. You can go to the playground story and set inline to true. Form requirement classes are used to display the error and warning messages, so those shouldn't be removed. Will probably need a different approach to fix this bug.
Also you'll probably want to use the hideLabel
prop vs. setting the title to empty for a11y purposes. (this doesn't fix the grid gap issue however)
6760d96
to
2edd95c
Compare
❌ Deploy Preview for v11-carbon-web-components failed. Why did it fail? →
|
@alisonjoseph Thanks for the review, have another I look I found relying on grid system to add more rows when needed works in all cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
d73bd2c
Closes #17750
Changelog
Changed
grid
toflex
so that it only addgap
if there is more than 1 child element to the wrapper.Removed
.#{$prefix}--form-requirement
it seems not used since there is no reference fromDropdown.tsx
Testing / Reviewing
No other inline elements:
When there are other inline elements: