fix(Tabs): Allow rendering Tabs and TabPanels conditionally again #17859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17859 +/- ##
=======================================
Coverage 80.14% 80.15%
=======================================
Files 406 406
Lines 14030 14031 +1
Branches 4343 4345 +2
=======================================
+ Hits 11245 11246 +1
Misses 2619 2619
Partials 166 166 ☔ View full report in Codecov by Sentry. |
This change allows users again to conditionally render children of TabPanels: If children are not filtered for nullish/falsy values before cloning them, `React.cloneElement` will fail. This regression has been introduced with commit: f406632, Tabs.tsx:L1257
remolueoend
force-pushed
the
fix/conditional-tab-panel
branch
from
b7669fb to
d3c961e
Compare
kennylam
approved these changes
Oct 29, 2024
Merged
via the queue into
carbon-design-system:main
with commit Oct 29, 2024
a24e338
39 of 40 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows users to conditionally render children of TabPanels again: If children are not filtered for nullish/falsy values before cloning them,
React.cloneElementwill fail with:Error: React.cloneElement(...): The argument must be a React element, but you passed null..This regression has been introduced with commit: f4066328a01bd9431f16ccc0c8b646f1f6d8a26e, Tabs.tsx:L1257
Changelog
Changed
TabPanelsfor nullish or falsy values usingisElementbefore cloning them.Testing / Reviewing