Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement codemod ibm-products-update-http-errors #17960

Merged
merged 8 commits into from
Dec 4, 2024
Merged

feat: implement codemod ibm-products-update-http-errors #17960

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2477e3c
feat(ibm-update-http-errors): implement ibm-update-http-errors codemod
makafsal Nov 4, 2024
265f7c7
feat(upgrade): include ibm-products-update-http-errors in migrate cli
makafsal Nov 4, 2024
93b21be
test(ibm-products-update-http-errors): include sample in fixtures folder
makafsal Nov 4, 2024
c8b0d5f
Merge branch 'main' into codemod-6306
2nikhiltom Nov 6, 2024
fa305a3
Merge branch 'main' into codemod-6306
riddhybansal Nov 11, 2024
4b79a08
chore: resolve merge conflict
makafsal Dec 2, 2024
695daaf
Merge branch 'codemod-6306' of github.com:makafsal/carbon into codemo…
makafsal Dec 2, 2024
b3cefb9
Merge branch 'main' into codemod-6306
guidari Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 82 additions & 0 deletions packages/upgrade/fixtures/ibm-products-update-http-errors-sample.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,82 @@
import React from 'react';
import {
HTTPError403,
HTTPError404,
HTTPErrorOther,
} from '@carbon/ibm-products';
import './_example.scss';

export const Example = () => (
<>
<HTTPError403
description="You are not authorized to access this resource."
errorCodeLabel="Error 403"
links={[
{
href: 'https://www.carbondesignsystem.com',
text: 'Carbon Design System',
},
{
href: 'https://github.com/carbon-design-system/ibm-products',
text: 'Carbon for IBM Products component library',
},
{
href: 'https://github.com/carbon-design-system/ibm-products',
text: 'Carbon for IBM Products component library',
},
{
href: 'https://github.com/carbon-design-system/ibm-products',
text: 'Carbon for IBM Products component library',
},
{
href: 'https://github.com/carbon-design-system/ibm-products',
text: 'Carbon for IBM Products component library',
},
]}
title="Forbidden"
/>
<HTTPError404
description="The page you are looking for was not found."
errorCodeLabel="Error 404"
links={[
{
href: 'https://www.carbondesignsystem.com',
text: 'Carbon Design System',
},
{
href: 'https://github.com/carbon-design-system/ibm-products',
text: 'Carbon for IBM Products component library',
},
]}
title="Page not found"
/>
<HTTPErrorOther
description="Received an invalid response."
errorCodeLabel="Error 502"
links={[
{
href: 'https://www.carbondesignsystem.com',
text: 'Carbon Design System',
},
{
href: 'https://github.com/carbon-design-system/ibm-products',
text: 'Carbon for IBM Products component library',
},
]}
title="Bad gateway"
/>
<MyComponent
errorCodeLabel="error"
links={[
{
href: 'https://www.carbondesignsystem.com',
text: 'Carbon Design System',
},
{
href: 'https://github.com/carbon-design-system/ibm-products',
text: 'Carbon for IBM Products component library',
},
]}
/>
</>
);
31 changes: 31 additions & 0 deletions packages/upgrade/src/upgrades.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,6 +359,37 @@
});
},
},
{
name: 'ibm-products-update-http-errors',
description:
'Rewrites HttpError403, HttpError404, HttpErrorOther to FullPageError',
migrate: async (options) => {
const transform = path.join(

Check warning on line 367 in packages/upgrade/src/upgrades.js

View check run for this annotation

Codecov / codecov/patch

packages/upgrade/src/upgrades.js#L366-L367 

Added lines #L366 - L367 were not covered by tests
TRANSFORM_DIR,
'ibm-products-update-http-errors.js'
);
const paths =
Array.isArray(options.paths) && options.paths.length > 0
? options.paths
: await glob(['**/*.js', '**/*.jsx', '**/*.ts', '**/*.tsx'], {

Check warning on line 374 in packages/upgrade/src/upgrades.js

View check run for this annotation

Codecov / codecov/patch

packages/upgrade/src/upgrades.js#L373-L374 

Added lines #L373 - L374 were not covered by tests
cwd: options.workspaceDir,
ignore: [
'**/es/**',
'**/lib/**',
'**/umd/**',
'**/node_modules/**',
'**/storybook-static/**',
],
});

await run({

Check warning on line 385 in packages/upgrade/src/upgrades.js

View check run for this annotation

Codecov / codecov/patch

packages/upgrade/src/upgrades.js#L385 

Added line #L385 was not covered by tests
dry: !options.write,
transform,
paths,
verbose: options.verbose,
});
},
},
],
},
{
Expand Down
82 changes: 82 additions & 0 deletions packages/upgrade/transforms/__testfixtures__/ibm-products-update-http-errors.input.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,82 @@
import React from 'react';
import {
HTTPError403,
HTTPError404,
HTTPErrorOther,
} from '@carbon/ibm-products';
import './_example.scss';

export const Example = () => (
<>
<HTTPError403
description="You are not authorized to access this resource."
errorCodeLabel="Error 403"
links={[
{
href: 'https://www.carbondesignsystem.com',
text: 'Carbon Design System',
},
{
href: 'https://github.com/carbon-design-system/ibm-products',
text: 'Carbon for IBM Products component library',
},
{
href: 'https://github.com/carbon-design-system/ibm-products',
text: 'Carbon for IBM Products component library',
},
{
href: 'https://github.com/carbon-design-system/ibm-products',
text: 'Carbon for IBM Products component library',
},
{
href: 'https://github.com/carbon-design-system/ibm-products',
text: 'Carbon for IBM Products component library',
},
]}
title="Forbidden"
/>
<HTTPError404
description="The page you are looking for was not found."
errorCodeLabel="Error 404"
links={[
{
href: 'https://www.carbondesignsystem.com',
text: 'Carbon Design System',
},
{
href: 'https://github.com/carbon-design-system/ibm-products',
text: 'Carbon for IBM Products component library',
},
]}
title="Page not found"
/>
<HTTPErrorOther
description="Received an invalid response."
errorCodeLabel="Error 502"
links={[
{
href: 'https://www.carbondesignsystem.com',
text: 'Carbon Design System',
},
{
href: 'https://github.com/carbon-design-system/ibm-products',
text: 'Carbon for IBM Products component library',
},
]}
title="Bad gateway"
/>
<MyComponent
errorCodeLabel="error"
links={[
{
href: 'https://www.carbondesignsystem.com',
text: 'Carbon Design System',
},
{
href: 'https://github.com/carbon-design-system/ibm-products',
text: 'Carbon for IBM Products component library',
},
]}
/>
</>
);
40 changes: 40 additions & 0 deletions packages/upgrade/transforms/__testfixtures__/ibm-products-update-http-errors.output.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
import { Link } from "@carbon/react";
import React from 'react';
import { FullPageError } from '@carbon/ibm-products';
import './_example.scss';

export const Example = () => (
<>
<FullPageError
description="You are not authorized to access this resource."
label="Error 403"
children={<><Link href={"https://www.carbondesignsystem.com"}>Carbon Design System</Link><br /><Link href={"https://github.com/carbon-design-system/ibm-products"}>Carbon for IBM Products component library</Link><br /><Link href={"https://github.com/carbon-design-system/ibm-products"}>Carbon for IBM Products component library</Link><br /><Link href={"https://github.com/carbon-design-system/ibm-products"}>Carbon for IBM Products component library</Link><br /><Link href={"https://github.com/carbon-design-system/ibm-products"}>Carbon for IBM Products component library</Link></>}
title="Forbidden"
kind="403" />
<FullPageError
description="The page you are looking for was not found."
label="Error 404"
children={<><Link href={"https://www.carbondesignsystem.com"}>Carbon Design System</Link><br /><Link href={"https://github.com/carbon-design-system/ibm-products"}>Carbon for IBM Products component library</Link></>}
title="Page not found"
kind="404" />
<FullPageError
description="Received an invalid response."
label="Error 502"
children={<><Link href={"https://www.carbondesignsystem.com"}>Carbon Design System</Link><br /><Link href={"https://github.com/carbon-design-system/ibm-products"}>Carbon for IBM Products component library</Link></>}
title="Bad gateway"
kind="custom" />
<MyComponent
errorCodeLabel="error"
links={[
{
href: 'https://www.carbondesignsystem.com',
text: 'Carbon Design System',
},
{
href: 'https://github.com/carbon-design-system/ibm-products',
text: 'Carbon for IBM Products component library',
},
]}
/>
</>
);
12 changes: 12 additions & 0 deletions packages/upgrade/transforms/__tests__/ibm-products-update-http-errors-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
/**
* Copyright IBM Corp. 2021, 2024
*
* This source code is licensed under the Apache-2.0 license found in the
* LICENSE file in the root directory of this source tree.
*/

'use strict';

const { defineTest } = require('jscodeshift/dist/testUtils');

defineTest(__dirname, 'ibm-products-update-http-errors');
Loading
Loading