-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(datepicker): focus trap in FireFox #17969
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17969 +/- ##
==========================================
+ Coverage 81.76% 81.78% +0.01%
==========================================
Files 406 406
Lines 14053 14048 -5
Branches 4408 4405 -3
==========================================
- Hits 11491 11489 -2
+ Misses 2400 2397 -3
Partials 162 162 ☔ View full report in Codecov by Sentry. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The content of this pull request will be made available as part of our next release. For the full schedule of upcoming releases, check out our Release Radar page. |
Hey there! v11.70.0 was just released that references this issue/PR. |
Closes #17663
Fixes focus trap in datepicker range variant during Keyboard Navigation in Firefox browser
Changelog
Removed
Removes the manual blur() function when closing the calendar to fix issues with focus in Firefox.
document.activeElement.blur()
blur() was initially added as a secondary safeguard to prevent the focus from staying on the input
Testing / Reviewing
open deploy preview in FireFox
Open DatePicker - "range with Calendar" storybook example
Select the dates using keyboard after selection of end date press tab and verify that the focus moves to the next focusable element in the DOM
Verify the clicking away from datepicker closes any open calendars