Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(on-focus-by-keyboard): avoid global reference to window object #1813

Merged
merged 1 commit into from
Feb 13, 2019
Merged

fix(on-focus-by-keyboard): avoid global reference to window object #1813

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/globals/js/misc/on-focus-by-keyboard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
const hasFocusout = 'onfocusout' in window;
const focusinEventName = hasFocusout ? 'focusin' : 'focus';
const focusoutEventName = hasFocusout ? 'focusout' : 'blur';

/**
* Differentiate between keyboard and mouse-triggered focusout/blur events
* @param {Element} node The element to attach event listeners to
Expand All @@ -10,6 +6,9 @@ const focusoutEventName = hasFocusout ? 'focusout' : 'blur';
* @returns {Handle} The handle to release the attached event handler
*/
export default function onFocusByKeyboard(node, name, callback) {
const hasFocusout = 'onfocusout' in window;
const focusinEventName = hasFocusout ? 'focusin' : 'focus';
const focusoutEventName = hasFocusout ? 'focusout' : 'blur';
/**
* Event types supported by this function
* @type {Object<string, string>}
Expand Down