fix(eslint-config-carbon): move best-practices.js back to cjs module export
#18377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
matthewgallo
force-pushed
the
18305-eslint-config-carbon-cjs-esm-change
branch
from
db34222 to
3ddc41b
Compare
matthewgallo
changed the title
best-practices.js back to cjs module exporteslint-config-carbon): move best-practices.js back to cjs module export
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18377 +/- ##
=======================================
Coverage 84.17% 84.17%
=======================================
Files 408 408
Lines 14435 14435
Branches 4660 4694 +34
=======================================
Hits 12150 12150
Misses 2120 2120
Partials 165 165 ☔ View full report in Codecov by Sentry. |
tay1orjones
approved these changes
Jan 17, 2025
Gururajj77
approved these changes
Jan 20, 2025
Merged
via the queue into
carbon-design-system:main
with commit Jan 20, 2025
f53c551
37 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18305
The export in
eslint-config-carbon/rules/best-practices.jswas changed here toexport default {}but no other file in the package or the package.json for this package was changed to ESM.This should address the errors we're seeing in #18305 and allow
ibm-productsto move to eslint v9.Changelog
Changed
config/eslint-config-carbon/rules/best-practices.jsTesting / Reviewing
Will verify PR checks in this PR