Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(icons): new icons dec 2024 - jan 2025 #18388

Merged
merged 8 commits into from
Feb 5, 2025
Merged

feat(icons): new icons dec 2024 - jan 2025 #18388

merged 8 commits into from
Feb 5, 2025

Conversation

DanaPaslaru
Copy link
Contributor

@DanaPaslaru DanaPaslaru commented Jan 21, 2025 •
edited
Loading

Submitting new UI icons from December 2024 through January 2025 all additions and updates approved by BXD

18 new icons
updated categories.yml with additions and updates
updated icons.yml with additions

updated ui-icon-master.ai file

Changelog

New

  • 32/array.svg
  • 32/asset-movement.svg
  • 32/avro.svg
  • 32/battery--error.svg
  • 32/battery--warning.svg
  • 32/channels.svg
  • 32/create-link.svg
  • 32/delivery-settings.svg
  • 32/ibm-consulting-advantage--agent.svg
  • 32/ibm-consulting-advantage--application.svg
  • 32/ibm-consulting-advantage--assistant.svg
  • 32/ibm--databand.svg
  • 32/kiosk-device.svg
  • 32/logo--git.svg
  • 32/logo--red-hat-ai-instructlab-on-ibm-cloud.svg
  • 32/multiuser-device.svg
  • 32/spyre-accelerator.svg
  • 32/trigger.svg

@DanaPaslaru
feat(icons): new icons dec 2024 - jan 2025
f78cbcf 
Submitting new UI icons from December 2024 through January 2025 all additions and updates approved by BXD

12 new icons

updated categories.yml with additions and updates
updated icons.yml with additions
@DanaPaslaru DanaPaslaru requested review from laurenmrice and a team as code owners January 21, 2025 17:39
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 21, 2025 •
edited
Loading

All contributors have signed the DCO.
Posted by the DCO Assistant Lite bot.

@DanaPaslaru
Copy link
Contributor Author

DanaPaslaru commented Jan 21, 2025 •
edited
Loading

I have read the DCO document and I hereby sign the DCO.

@emyarod
Copy link
Member

emyarod commented Jan 21, 2025 •
edited
Loading

@DanaPaslaru I think you may need to remove the quote from your comment for it to pass the DCO check

@DanaPaslaru
Update ui-icon-master.ai
98b0fc9 
updated ui icon master file .ai
laurenmrice
laurenmrice approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@laurenmrice laurenmrice mentioned this pull request Jan 24, 2025
Closed
12 tasks
@DanaPaslaru
added 6 new ui icons
6876aa1 
added 6 new icons
updated categories.yml with additions and updates
updated icons.yml with additions and updates

updated ui-icon-master.ai file
emyarod
emyarod approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

emyarod
emyarod reviewed Jan 31, 2025
View reviewed changes
packages/icons/icons.yml Outdated
@@ -1586,6 +1595,16 @@
- asset
sizes:
- 32
- name: asset--movement
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: asset--movement
- name: asset-movement

it looks like this extra dash is what's causing the test failures

@DanaPaslaru
Update icons.yml
e0ccd7b 
updated icons.yml with suggested change:
from name "asset--movement" to "asset-movement"
@netlify Netlify
Copy link

netlify bot commented Feb 3, 2025 •
edited
Loading

✅ Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit f5e591d
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67a35afe2636db0008e7ac3e
😎 Deploy Preview https://deploy-preview-18388--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Feb 3, 2025 •
edited
Loading

✅ Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit f5e591d
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67a35afe105d52000825ea4d
😎 Deploy Preview https://deploy-preview-18388--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Feb 3, 2025 •
edited
Loading

✅ Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f5e591d
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67a35afe2636db0008e7ac3a
😎 Deploy Preview https://deploy-preview-18388--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Feb 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.10%. Comparing base (2f99a47) to head (f5e591d).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #18388   +/-   ##
=======================================
  Coverage   84.10%   84.10%           
=======================================
  Files         408      408           
  Lines       14466    14466           
  Branches     4656     4656           
=======================================
  Hits        12166    12166           
  Misses       2134     2134           
  Partials      166      166

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kennylam kennylam requested a review from a team as a code owner February 5, 2025 12:35
@kennylam kennylam enabled auto-merge February 5, 2025 12:36
@kennylam kennylam added this pull request to the merge queue Feb 5, 2025
Merged via the queue into carbon-design-system:main with commit 3727760 Feb 5, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod emyarod approved these changes

@kennylam kennylam kennylam approved these changes

@laurenmrice laurenmrice laurenmrice approved these changes

@tay1orjones tay1orjones Awaiting requested review from tay1orjones tay1orjones was automatically assigned from carbon-design-system/developers-system-reviewers

Assignees
No one assigned
Labels
status: one more review 👀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DanaPaslaru @emyarod @kennylam @laurenmrice