Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Pictograms): new pictograms v25 #18391

Merged
merged 4 commits into from
Jan 31, 2025

Conversation

dudley-ibm
Copy link
Contributor

@dudley-ibm dudley-ibm commented Jan 21, 2025

Closes following issues: 166/170/178/199/231/239/240/242/250

New pictograms and their (Category):
poughkeepsie--bridge (Cities)
stuttgart--tv-tower (Cities)
ehningen--tech-campus-01 (Cities)
ehningen--tech-campus-02 (Cities)
b2b-commerce (Industry)
waving-hand (Lifestyle)
ibm--granite (AI)
watsonx--assistant (Watson)
ibm--one-madison-avenue (Cities)

New pictogram and NEW (Category):
qiskit (Quantum)

Replaced existing deprecated artwork per @tay1orjones suggestions:
ibm--z (IBM)
updated deprecated.yml with current ibm--z deprecation removed from that file in order to unhide new ibm--z artwork from the sites

Testing / Reviewing

New additions and updates need to appear in both sites:

Copy link

netlify bot commented Jan 21, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 80795f3
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/679d2c12aa16c40008859de6
😎 Deploy Preview https://deploy-preview-18391--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 21, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 80795f3
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/679d2c129f424f00089e160a
😎 Deploy Preview https://deploy-preview-18391--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 21, 2025

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 80795f3
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/679d2c129f424f00089e160c
😎 Deploy Preview https://deploy-preview-18391--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.16%. Comparing base (3893572) to head (80795f3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18391   +/-   ##
=======================================
  Coverage   84.16%   84.16%           
=======================================
  Files         408      408           
  Lines       14450    14450           
  Branches     4646     4646           
=======================================
  Hits        12162    12162           
  Misses       2124     2124           
  Partials      164      164           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tay1orjones tay1orjones requested a review from a team as a code owner January 31, 2025 16:57
@tay1orjones
Copy link
Member

@ariellalgilmore just a heads up, the way I fixed the CI on this one was following the docs on working with icons and pictograms

4. Is the CI check failing because of a snapshot change?
If so, you will need to help out the contributor by updating the snapshot based
on the changes. To update snapshot, you'll need to rebuild the relevant packages
and then run Jest.

If pictograms changed, it would be:
```bash
yarn lerna run build --scope='@carbon/pictograms-react' --include-dependencies
yarn test:e2e -u
```

@tay1orjones tay1orjones added this pull request to the merge queue Jan 31, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 31, 2025
@tay1orjones tay1orjones enabled auto-merge January 31, 2025 20:01
@tay1orjones tay1orjones added this pull request to the merge queue Jan 31, 2025
Merged via the queue into carbon-design-system:main with commit bc04c97 Jan 31, 2025
37 checks passed
ariellalgilmore pushed a commit to ariellalgilmore/carbon that referenced this pull request Feb 3, 2025
* feat(Pictograms): new pictograms v25

* chore(pictograms): update snaps

---------

Co-authored-by: Taylor Jones <taylor.jones826@gmail.com>
Co-authored-by: Taylor Jones <tay1orjones@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants