-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Pictograms): new pictograms v25 #18391
feat(Pictograms): new pictograms v25 #18391
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18391 +/- ##
=======================================
Coverage 84.16% 84.16%
=======================================
Files 408 408
Lines 14450 14450
Branches 4646 4646
=======================================
Hits 12162 12162
Misses 2124 2124
Partials 164 164 ☔ View full report in Codecov by Sentry. |
@ariellalgilmore just a heads up, the way I fixed the CI on this one was following the docs on working with icons and pictograms carbon/docs/developer-handbook.md Lines 580 to 584 in c00b460
carbon/docs/developer-handbook.md Lines 593 to 598 in c00b460
|
bc04c97
* feat(Pictograms): new pictograms v25 * chore(pictograms): update snaps --------- Co-authored-by: Taylor Jones <taylor.jones826@gmail.com> Co-authored-by: Taylor Jones <tay1orjones@users.noreply.github.com>
Closes following issues: 166/170/178/199/231/239/240/242/250
New pictograms and their (Category):
poughkeepsie--bridge (Cities)
stuttgart--tv-tower (Cities)
ehningen--tech-campus-01 (Cities)
ehningen--tech-campus-02 (Cities)
b2b-commerce (Industry)
waving-hand (Lifestyle)
ibm--granite (AI)
watsonx--assistant (Watson)
ibm--one-madison-avenue (Cities)
New pictogram and NEW (Category):
qiskit (Quantum)
Replaced existing deprecated artwork per @tay1orjones suggestions:
ibm--z (IBM)
updated deprecated.yml with current ibm--z deprecation removed from that file in order to unhide new ibm--z artwork from the sites
Testing / Reviewing
New additions and updates need to appear in both sites:
ibm--z
pictogram incarbon-website
carbon-website#4438ibm--z
pictogram indesign-language-website
design-language-website#1402