Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(combo-box): ai-label with close style #18432

Conversation

ariellalgilmore
Copy link
Member

Closes #18392

before (overlapping AILabel and Close)
Screenshot 2025-01-24 at 10 40 18 AM

after (spaced out evenly)
Screenshot 2025-01-24 at 10 40 29 AM

Changelog

Changed

  • update styles to look for inner wrapper first then ai-label. remove duplicate styles

Testing / Reviewing

confirm combobox ai-label is styled correctly
make sure other list-box components aren't effected with ai-label styles

Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit b0379d7
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/6797f61a15024e000877991a
😎 Deploy Preview https://deploy-preview-18432--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit b0379d7
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6797f61a9a289b0008669000
😎 Deploy Preview https://deploy-preview-18432--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 24, 2025

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit b0379d7
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6797f61a4b08af0008e89c3b
😎 Deploy Preview https://deploy-preview-18432--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.16%. Comparing base (9ec6285) to head (b0379d7).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18432   +/-   ##
=======================================
  Coverage   84.16%   84.16%           
=======================================
  Files         408      408           
  Lines       14449    14449           
  Branches     4696     4666   -30     
=======================================
  Hits        12161    12161           
+ Misses       2124     2123    -1     
- Partials      164      165    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ariellalgilmore ariellalgilmore marked this pull request as ready for review January 27, 2025 21:09
@ariellalgilmore ariellalgilmore requested a review from a team as a code owner January 27, 2025 21:09
@annawen1
Copy link
Member

Are we fixing the issue in Web Components as well? This is what I see when I choose an option from the menu in WC
https://deploy-preview-18432--v11-carbon-web-components.netlify.app/?path=/story/components-combo-box--with-ai-label

Screenshot 2025-01-27 at 4 14 20 PM

@ariellalgilmore
Copy link
Member Author

Are we fixing the issue in Web Components as well? This is what I see when I choose an option from the menu in WC https://deploy-preview-18432--v11-carbon-web-components.netlify.app/?path=/story/components-combo-box--with-ai-label

Screenshot 2025-01-27 at 4 14 20 PM

hmmm maybe i can comment this in the syncing epic...?

Copy link
Contributor

@2nikhiltom 2nikhiltom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@annawen1 annawen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gururajj77 Gururajj77 added this pull request to the merge queue Jan 28, 2025
Merged via the queue into carbon-design-system:main with commit 051cedd Jan 28, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: ComboBox decorator overlaps with "X" button to cancel out the current selection
4 participants