-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(combo-box): ai-label with close style #18432
fix(combo-box): ai-label with close style #18432
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18432 +/- ##
=======================================
Coverage 84.16% 84.16%
=======================================
Files 408 408
Lines 14449 14449
Branches 4696 4666 -30
=======================================
Hits 12161 12161
+ Misses 2124 2123 -1
- Partials 164 165 +1 ☔ View full report in Codecov by Sentry. |
Are we fixing the issue in Web Components as well? This is what I see when I choose an option from the menu in WC |
hmmm maybe i can comment this in the syncing epic...? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
051cedd
Closes #18392
before (overlapping AILabel and Close)
after (spaced out evenly)
Changelog
Changed
Testing / Reviewing
confirm combobox ai-label is styled correctly
make sure other list-box components aren't effected with ai-label styles