Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: codemod to enable v12 tile default icons #18453

Conversation

riddhybansal
Copy link
Contributor

@riddhybansal riddhybansal commented Jan 28, 2025

Closes #18365
Enable v12 tile radio icons via feature flags
Wrap Tile and TileGroup components with FeatureFlags enableV12TileDefaultIcons

      Transforms:
      1. TileGroup with Tiles:
      <TileGroup>
        <Tile>...</Tile>
      </TileGroup>
  
      Into:
      <FeatureFlags enableV12TileDefaultIcons>
        <TileGroup>
          <Tile>...</Tile>
        </TileGroup>
      </FeatureFlags>
  
      2. Standalone Tile:
      <Tile>...</Tile>
  
      Into:
      <FeatureFlags enableV12TileDefaultIcons>
        <Tile>...</Tile>
      </FeatureFlags>

Changeloga

New

  • Added codemod to automatically wrap RadioTile components with FeatureFlags enableV12TileRadioIcons

Removed

  • None

Testing / Reviewing

  • Run yarn build in packages/upgrade
  • Using the sample project in the fixtures directory:
    • Run the default upgrade command: ../../bin/carbon-upgrade.js
    • Choose the sample-project directory
    • Choose the default path
    • Verify no errors occur and that changes are printed to the console (in this case import changes)
    • Run the migration command: ../../bin/carbon-upgrade.js migrate update-carbon-components-react-import-to-scoped
    • Choose the sample-project directory
    • Verify no errors occur and that changes are printed to the console

@riddhybansal riddhybansal requested a review from a team as a code owner January 28, 2025 09:14
Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit ee7db01
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/679942243ad55a0008189672
😎 Deploy Preview https://deploy-preview-18453--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit ee7db01
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67994224f172b500083633c0
😎 Deploy Preview https://deploy-preview-18453--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ee7db01
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67994224783fb700083b7128
😎 Deploy Preview https://deploy-preview-18453--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 84.13%. Comparing base (051cedd) to head (ee7db01).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
packages/upgrade/src/upgrades.js 0.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18453      +/-   ##
==========================================
- Coverage   84.16%   84.13%   -0.04%     
==========================================
  Files         408      408              
  Lines       14449    14455       +6     
  Branches     4696     4649      -47     
==========================================
  Hits        12161    12161              
- Misses       2124     2129       +5     
- Partials      164      165       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@riddhybansal riddhybansal force-pushed the codemod_to_enable_v12_tile_default_icons branch from 6df772f to 5e4b2f3 Compare January 28, 2025 19:27
@riddhybansal riddhybansal added this pull request to the merge queue Feb 5, 2025
Merged via the queue into carbon-design-system:main with commit 2f99a47 Feb 5, 2025
37 checks passed
@riddhybansal riddhybansal deleted the codemod_to_enable_v12_tile_default_icons branch February 5, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Research/Write codemod for enable-v12-tile-default-icons
3 participants