refactor(project): add react package #2421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…em#1767) * docs(OverflowMenu): support `flipped` storybook knob * chore: bump carbon-components version * fix(OverflowMenu): pass trigger node and flip prop through FloatingMenu * docs(FloatingMenu): fix typo * fix(OverflowMenu): handle click on trigger button div
…n-system#1716) * docs(ContentSwitcher): use experimental icons * fix(ContentSwitcher): match vanilla markup * feat(ContentSwitcher): support `disabled` attribute * chore: bump carbon-components version
…n-design-system#1747) * fix(TimePicker): update markup to match experimental component * docs(TimePicker): fix typo
* fix(TileGroup): use fieldset element for TileGroup wrapper * fix(Tile): place label after input control * test(Tile): account for new React.Fragment wrapper
…n-design-system#1808) * chore: update offline package mirrors * docs(TextInput): expose `defaultValue` prop as Storybook knob
…#1654) * docs(FormItem): add `hideLabel` prop to storybook example * feat(NumberInput): align NumberInput markup with vanilla repo * test(NumberInput): remove form item wrapper check * Revert "feat(NumberInput): align NumberInput markup with vanilla repo" This reverts commit 6abb5fcf2a5b2d9a329ce9739fee22628df4e132. * refactor(NumberInput): set default label value to empty string * Revert "test(NumberInput): remove form item wrapper check" This reverts commit c780e6a85231b948db541a119ba2c2a4602f9db9. * refactor(NumberInput): set default labelText based on feature flag * fix(NumberInput): match vanilla markup * fix(NumberInput): match vanilla markup and use caret glyph icons * refactor(NumberInput): use React fragment syntax
…n-system#1816) * fix(ui-shell): remove aria menu keyhandlers * fix(ui-shell): remove unused variables * fix(ui-shell): return focus to menu button on escape * fix(ui-shell): remove unused variables * fix(ui-shell): run prettier and update snap shots * fix(ui-shell): handle keydown enter on menuitems * chore(ui-shell): update snapshots * fix(ui-shell): refactor some event handler logic with Josh * chore(ui-shell): update snapshots
…sign-system#1809) * docs(Storybook): more detailed doc for using our Storybook * Update docs/components.md Co-Authored-By: asudoh <asudoh@gmail.com> * Update README.md Co-Authored-By: asudoh <asudoh@gmail.com> * docs(Storybook): minor updates
…em#1784) * fix(tab-content): add prefix to content classname * fix(tabs): remove unnecessary classname
…sign-system#1802) * feat(ListBoxMenuIcon): support translatable SVG icon title * feat(MultiSelect): pass custom SVG titles to ListBoxMenuIcon * chore: update snapshot * refactor(MultiSelect): use callback pattern for assigning SVG title * chore: update snapshot * fix(MultiSelect): remove default `translateWithid` prop value * chore: update snapshot
…#1800) * chore: bump carbon-components version * feat(PaginationV2): add experimental Pagination * chore: bump carbon-components version * fix(Pagination): render page range only when page input is enabled * refactor(Pagination): remove `isLastPage` prop
…arbon-design-system#1823) * chore: Update wai-aria on tooltip. resolve carbon-design-system#1494 * chore: Updates test. * chore: reverts triggers to div with button roles.
* refactor(AccordionSkeleton): Converted skeleton from class to functional component * feat(AccordionSkeleton): Added option to show first item opened or not * fix(AccordionSkeleton): Number of items differ for first item opened and closed variations * feat(AccordionSkeleton): Option to set number of items added
…-system#1830) * chore: bump webpack-dev-server in example package.json * fix: use caret prefix
* Update 'InnerClickListener' - check if event target exists in DOM - if it does not exist, should not trigger onClickOutside * Run prettier * Implemented suggestions fix * Fix failing tests * reordering boolean test elements * Trying different approach for IE fix * Attempt to fix failing test * Attempt fix 2 - check if target === body * Testing simpler version * Test simpler 2 * fix(InnerClickListener): added test case and reverted to previous fix * fix(InnerClickListener): Removing outdated comment
…system#1835) * feat(AccordionItem): add experimental Accordion Item * test(AccordionItem): Fixes tests for new icon components * chore(AccordionItem): Use aria label prop * fix(AccordionItem): Remove role null * chore(AccordionItem): Remove icon prop * chore(AccorionItem): Adds role null back into legacy icon
(carbon-design-system#1797) * docs(examples): usage of react-router, resolves carbon-design-system#795 * docs(examples): address prettier errors * docs(examples): remove svg * docs(examples): address review comments and use prebuilt css * docs(examples): accidentally updated incorrect file
…m#1787) * fix(components): avoid being shown as ForwardRef Fixes carbon-design-system#1786. * chore: use ForwardRef(ComponentName) * chore(components): avoid Object.assign() for ref forwarding components * Update src/components/Checkbox/Checkbox.js Co-Authored-By: asudoh <asudoh@gmail.com> * chore: bring missing React.forwardRef() call back * chore: bring missing React.forwardRef() call back
…design-system#1726) * feat(ProgressIndicator): update SVG icons and match experimental markup * feat(ProgressIndicator): support experimental overflow tooltip * fix(ProgressIndicator): avoid passing style prop to nested tooltips * fix(ProgressIndicator): allow assignment of tooltip ID for each step * refactor(ProgressIndicator): use render prop for overflow tooltip * refactor(ProgressIndicator): set default progress step label * refactor(ProgressIndicator): remove else-returns
* docs(g11n): notes of globalization Refs carbon-design-system#1335. * Update docs/g11n.md Co-Authored-By: asudoh <asudoh@gmail.com>
…stem#1840) `updatePosition()` used to be called in `cDM()` for initial prop->state sync. Given we have got new prop->state sync code in `v10`, such logic is no longer needed. Fixes carbon-design-system#1839 for `v10`.
* fix(tile): move aria-label, use unique ids * fix(tile): re-add aria-label to chevron * fix(tile): add unique id * fix(tile): move uid call into creation * fix(tile): merge master and add ID prop * Update src/components/Tile/Tile.js Co-Authored-By: dakahn <40970507+dakahn@users.noreply.github.com> * Update src/components/Tile/Tile.js Co-Authored-By: dakahn <40970507+dakahn@users.noreply.github.com> * Update src/components/Tile/Tile.js Co-Authored-By: dakahn <40970507+dakahn@users.noreply.github.com> * Update src/components/Tile/Tile.js Co-Authored-By: dakahn <40970507+dakahn@users.noreply.github.com>
Changing the label of stale bot issue closers to `inactive` from `wontfix`
* fix(modal): change title add proper headings * chore(modal): update snaps * chore(modal): update snapshot * fix(modal): add back the title attr * chore(modal): update snapshots
This change removes RTL plugin of Storybook. Though it's a nice add-on, we require an additional build step to generate RTL version of CSS and that Storybook add-on does not seem to kick off an altern ate build. Refs carbon-design-system#2053. Refs carbon-design-system#2314. Refs carbon-design-system#2286.
* docs(TextInput): describe PropTypes * chore: update carbon peer dependencies * docs(TextInput): modify `type` storybook knob * feat(TextInput): add password visibility toggle * docs(TextInput): add `text` option to storybook types knob * test(TextInput): test password visibility toggle TextInput * refactor(TextInput): create PasswordInput component * feat(PasswordInput): allow custom `alt` text attribute * refactor(PasswordInput): pull out shared function * feat(PasswordInput): display tooltip text on hover of visibility toggle * feat: add ControlledPasswordInput component * feat(ControlledPasswordInput): set default `type` prop value * test(TextInput): add tests for PasswordInput and ControlledPasswordInput * feat(PasswordInput): allow custom password visibility toggle alt text * fix(PasswordInput): export named password input components * docs(TextInput): refactor story for storybook v4 * fix(PasswordInput): match experimental spec * fix(PasswordInput): rename attribute * test(TextInput): checkout test from master * test(TextInput): fix console warning * feat(ControlledPasswordInput): match v10 spec * test(PasswordInput): rename suite * test(ControlledPasswordInput): add test suite * fix(TextInput): add data-invalid attribute for v10 * refactor: remove v9 code * chore: sync forwardRef changes * chore: update lockfile * docs: revert comment changes * docs: space between propTypes
…carbon-components into refactor/add-react-to-project
…nents into refactor/add-react-to-project
…carbon-components into refactor/add-react-to-project
|
Deploy preview for the-carbon-components failed. Built with commit 17a89c1 https://app.netlify.com/sites/the-carbon-components/deploys/5cd320843d06a70009724c6b |
tw15egan
approved these changes
May 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take two of #2417, accidentally squashed and merged 🤦♂