feat(downshift): allow passing additional props to Downshift #2726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for the-carbon-components ready! Built with commit 4671da2 https://deploy-preview-2726--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react failed. Built with commit 4671da2 https://app.netlify.com/sites/carbon-components-react/deploys/5cdc1a5660faaa000abd3b16 |
asudoh
approved these changes
May 14, 2019
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will allow users to pass additional props to Downshift. This is useful for when for example the app is running in a shadowRoot and the user needs to pass an environment object to Downshift (which is an issue I'm currently running into).
See downshift-js/downshift#536
Changelog
Changed
The following files have the same changes applied to them:
Added optional prop downshiftProps which is merged with component's own Downshift props (component's props take precedence) and passed to Downshift.