Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(radio-button): left/right alignment #2886

Closed
wants to merge 3 commits into from
Closed

fix(radio-button): left/right alignment #2886

wants to merge 3 commits into from

Conversation

youda97
Copy link
Contributor

@youda97 youda97 commented May 30, 2019

Closes #2286

@emyarod
Copy link
Member

emyarod commented May 30, 2019

this appears to be a duplicate of #2870?

@netlify
Copy link

netlify bot commented May 30, 2019

Deploy preview for the-carbon-components ready!

Built with commit 4e43f1b

https://deploy-preview-2886--the-carbon-components.netlify.com

@asudoh
Copy link
Contributor

asudoh commented May 30, 2019

@youda97 Are you trying to add right-aligned vertical radio button...?

@netlify
Copy link

netlify bot commented May 30, 2019

Deploy preview for carbon-components-react ready!

Built with commit 4e43f1b

https://deploy-preview-2886--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented May 30, 2019 •
edited
Loading

Deploy preview for the-carbon-components ready!

Built with commit beb4f2a

https://deploy-preview-2886--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented May 30, 2019 •
edited
Loading

Deploy preview for carbon-components-react ready!

Built with commit beb4f2a

https://deploy-preview-2886--carbon-components-react.netlify.com

@youda97
Copy link
Contributor Author

youda97 commented May 31, 2019

@asudoh There's a class #{$prefix}--radio-button-wrapper--label-left that positions the labels to the left, so the radios need to be right aligned at that point

@youda97 youda97 requested review from asudoh and emyarod June 2, 2019 17:48
asudoh
asudoh approved these changes Jun 3, 2019
View reviewed changes
Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @youda97!

emyarod
emyarod reviewed Jun 3, 2019
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we expose this change in the react and vanilla documentation?

@asudoh asudoh mentioned this pull request Jun 3, 2019
Merged
@asudoh
Copy link
Contributor

asudoh commented Jun 3, 2019

After mulling over about this addition, I saw that radio group users would have to add a class to radio group and another class to radio button to flip label/button positioning. Created #2914 to address that.

@emyarod
Copy link
Member

emyarod commented Jun 4, 2019

superseded by #2914

@emyarod emyarod closed this Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod emyarod left review comments

@asudoh asudoh asudoh approved these changes

@dakahn dakahn dakahn approved these changes

Assignees
No one assigned
Labels
status: one more review 👀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Carbon 10: Radio button] styling issues
4 participants
@youda97 @emyarod @asudoh @dakahn