-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(radio-button): left/right alignment #2886
Conversation
this appears to be a duplicate of #2870? |
Deploy preview for the-carbon-components ready! Built with commit 4e43f1b https://deploy-preview-2886--the-carbon-components.netlify.com |
@youda97 Are you trying to add right-aligned vertical radio button...? |
Deploy preview for carbon-components-react ready! Built with commit 4e43f1b https://deploy-preview-2886--carbon-components-react.netlify.com |
Deploy preview for the-carbon-components ready! Built with commit beb4f2a https://deploy-preview-2886--the-carbon-components.netlify.com |
Deploy preview for carbon-components-react ready! Built with commit beb4f2a https://deploy-preview-2886--carbon-components-react.netlify.com |
@asudoh There's a class |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 - Thanks @youda97!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we expose this change in the react and vanilla documentation?
After mulling over about this addition, I saw that radio group users would have to add a class to radio group and another class to radio button to flip label/button positioning. Created #2914 to address that. |
superseded by #2914 |
Closes #2286