-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Button): require iconDescription for icon-only #2929
fix(Button): require iconDescription for icon-only #2929
Conversation
Deploy preview for the-carbon-components ready! Built with commit b28c024 https://deploy-preview-2929--the-carbon-components.netlify.com |
Deploy preview for carbon-components-react failed. Built with commit b28c024 https://app.netlify.com/sites/carbon-components-react/deploys/5cf7d5ebafc9f70008ddc211 |
Deploy preview for carbon-elements ready! Built with commit b28c024 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
…tem#2929) * fix(Button): require iconDescription for icon-only Fixes carbon-design-system#2884. * chore(test): update snapshots
…2906) * fix(overflow-menu): updated aria-label and roles, made ul a sibling * fix(overflow-menu): removing unused var * fix(overflow-menu): update snapshots * chore(project): use yarn policies to set version to 1.16.0 (#2902) * chore(project): use yarn policies to set version to 1.16.0 * chore(project): update prettier to ignore .yarn folder * fix(modal): support different numbers of buttons (#2900) Fixes #2325. * chore(examples): build examples based on whitelist (#2903) * chore(release): v10.3.0-rc.2 (#2908) * fix(overflow-menu): update defaultprops for Menu * fix(overflow-menu): removed add'l this.props * fix(overflow-menu): update snapshots * fix(radio-button): group-level label/button alignment (#2914) Fixes #2286. * Fix sass error (#2905) * chore(deps): bump sshpk in /packages/react/examples/create-react-app (#2915) Bumps [sshpk](https://github.com/joyent/node-sshpk) from 1.13.1 to 1.16.1. - [Release notes](https://github.com/joyent/node-sshpk/releases) - [Commits](TritonDataCenter/node-sshpk@v1.13.1...v1.16.1) * fix(overflow-menu): rollback ul changes * fix(tooltip): set width to content max (#2923) * chore(deps): bump safer-eval (#2930) Bumps [safer-eval](https://github.com/commenthol/safer-eval) from 1.2.3 to 1.3.3. - [Release notes](https://github.com/commenthol/safer-eval/releases) - [Commits](commenthol/safer-eval@v1.2.3...v1.3.3) Signed-off-by: dependabot[bot] <support@github.com> * chore(deps): bump safer-eval in /packages/colors/examples/preview (#2931) Bumps [safer-eval](https://github.com/commenthol/safer-eval) from 1.2.3 to 1.3.3. - [Release notes](https://github.com/commenthol/safer-eval/releases) - [Commits](commenthol/safer-eval@v1.2.3...v1.3.3) Signed-off-by: dependabot[bot] <support@github.com> * fix(button): require iconDescription for icon-only (#2929) * fix(Button): require iconDescription for icon-only Fixes #2884. * chore(test): update snapshots * fix(overflow-menu): update snapshots * Revert "fix(overflow-menu): update snapshots" This reverts commit 1015db6. * fix(overflow-menu): update snapshots * `Revert "fix(overflow-menu): update snapshots" This reverts commit 6fe35a6. * fix(overflow-menu): update snapshots * chore(react): remove redundant version field
…arbon-design-system#2906) * fix(overflow-menu): updated aria-label and roles, made ul a sibling * fix(overflow-menu): removing unused var * fix(overflow-menu): update snapshots * chore(project): use yarn policies to set version to 1.16.0 (carbon-design-system#2902) * chore(project): use yarn policies to set version to 1.16.0 * chore(project): update prettier to ignore .yarn folder * fix(modal): support different numbers of buttons (carbon-design-system#2900) Fixes carbon-design-system#2325. * chore(examples): build examples based on whitelist (carbon-design-system#2903) * chore(release): v10.3.0-rc.2 (carbon-design-system#2908) * fix(overflow-menu): update defaultprops for Menu * fix(overflow-menu): removed add'l this.props * fix(overflow-menu): update snapshots * fix(radio-button): group-level label/button alignment (carbon-design-system#2914) Fixes carbon-design-system#2286. * Fix sass error (carbon-design-system#2905) * chore(deps): bump sshpk in /packages/react/examples/create-react-app (carbon-design-system#2915) Bumps [sshpk](https://github.com/joyent/node-sshpk) from 1.13.1 to 1.16.1. - [Release notes](https://github.com/joyent/node-sshpk/releases) - [Commits](TritonDataCenter/node-sshpk@v1.13.1...v1.16.1) * fix(overflow-menu): rollback ul changes * fix(tooltip): set width to content max (carbon-design-system#2923) * chore(deps): bump safer-eval (carbon-design-system#2930) Bumps [safer-eval](https://github.com/commenthol/safer-eval) from 1.2.3 to 1.3.3. - [Release notes](https://github.com/commenthol/safer-eval/releases) - [Commits](commenthol/safer-eval@v1.2.3...v1.3.3) Signed-off-by: dependabot[bot] <support@github.com> * chore(deps): bump safer-eval in /packages/colors/examples/preview (carbon-design-system#2931) Bumps [safer-eval](https://github.com/commenthol/safer-eval) from 1.2.3 to 1.3.3. - [Release notes](https://github.com/commenthol/safer-eval/releases) - [Commits](commenthol/safer-eval@v1.2.3...v1.3.3) Signed-off-by: dependabot[bot] <support@github.com> * fix(button): require iconDescription for icon-only (carbon-design-system#2929) * fix(Button): require iconDescription for icon-only Fixes carbon-design-system#2884. * chore(test): update snapshots * fix(overflow-menu): update snapshots * Revert "fix(overflow-menu): update snapshots" This reverts commit 1015db6. * fix(overflow-menu): update snapshots * `Revert "fix(overflow-menu): update snapshots" This reverts commit 6fe35a6. * fix(overflow-menu): update snapshots * chore(react): remove redundant version field
…arbon-design-system#2906) * fix(overflow-menu): updated aria-label and roles, made ul a sibling * fix(overflow-menu): removing unused var * fix(overflow-menu): update snapshots * chore(project): use yarn policies to set version to 1.16.0 (carbon-design-system#2902) * chore(project): use yarn policies to set version to 1.16.0 * chore(project): update prettier to ignore .yarn folder * fix(modal): support different numbers of buttons (carbon-design-system#2900) Fixes carbon-design-system#2325. * chore(examples): build examples based on whitelist (carbon-design-system#2903) * chore(release): v10.3.0-rc.2 (carbon-design-system#2908) * fix(overflow-menu): update defaultprops for Menu * fix(overflow-menu): removed add'l this.props * fix(overflow-menu): update snapshots * fix(radio-button): group-level label/button alignment (carbon-design-system#2914) Fixes carbon-design-system#2286. * Fix sass error (carbon-design-system#2905) * chore(deps): bump sshpk in /packages/react/examples/create-react-app (carbon-design-system#2915) Bumps [sshpk](https://github.com/joyent/node-sshpk) from 1.13.1 to 1.16.1. - [Release notes](https://github.com/joyent/node-sshpk/releases) - [Commits](TritonDataCenter/node-sshpk@v1.13.1...v1.16.1) * fix(overflow-menu): rollback ul changes * fix(tooltip): set width to content max (carbon-design-system#2923) * chore(deps): bump safer-eval (carbon-design-system#2930) Bumps [safer-eval](https://github.com/commenthol/safer-eval) from 1.2.3 to 1.3.3. - [Release notes](https://github.com/commenthol/safer-eval/releases) - [Commits](commenthol/safer-eval@v1.2.3...v1.3.3) Signed-off-by: dependabot[bot] <support@github.com> * chore(deps): bump safer-eval in /packages/colors/examples/preview (carbon-design-system#2931) Bumps [safer-eval](https://github.com/commenthol/safer-eval) from 1.2.3 to 1.3.3. - [Release notes](https://github.com/commenthol/safer-eval/releases) - [Commits](commenthol/safer-eval@v1.2.3...v1.3.3) Signed-off-by: dependabot[bot] <support@github.com> * fix(button): require iconDescription for icon-only (carbon-design-system#2929) * fix(Button): require iconDescription for icon-only Fixes carbon-design-system#2884. * chore(test): update snapshots * fix(overflow-menu): update snapshots * Revert "fix(overflow-menu): update snapshots" This reverts commit 1015db6. * fix(overflow-menu): update snapshots * `Revert "fix(overflow-menu): update snapshots" This reverts commit 6fe35a6. * fix(overflow-menu): update snapshots * chore(react): remove redundant version field
Fixes #2884.
Changelog
Changed
<Button>
to ensure its check foriconDescription
's existence only happens if the button is icon-only.Removed
iconDescription
.Testing / Reviewing
Testing should make sure our React
<Button>
is not broken.