fix(Button): require iconDescription for icon-only #2929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for the-carbon-components ready! Built with commit b28c024 https://deploy-preview-2929--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react failed. Built with commit b28c024 https://app.netlify.com/sites/carbon-components-react/deploys/5cf7d5ebafc9f70008ddc211 |
|
Deploy preview for carbon-elements ready! Built with commit b28c024 |
joshblack
approved these changes
Jun 5, 2019
harpality
pushed a commit
to harpality/carbon
that referenced
this pull request
Jun 5, 2019
…tem#2929) * fix(Button): require iconDescription for icon-only Fixes carbon-design-system#2884. * chore(test): update snapshots
joshblack
pushed a commit
that referenced
this pull request
Jun 12, 2019
…2906) * fix(overflow-menu): updated aria-label and roles, made ul a sibling * fix(overflow-menu): removing unused var * fix(overflow-menu): update snapshots * chore(project): use yarn policies to set version to 1.16.0 (#2902) * chore(project): use yarn policies to set version to 1.16.0 * chore(project): update prettier to ignore .yarn folder * fix(modal): support different numbers of buttons (#2900) Fixes #2325. * chore(examples): build examples based on whitelist (#2903) * chore(release): v10.3.0-rc.2 (#2908) * fix(overflow-menu): update defaultprops for Menu * fix(overflow-menu): removed add'l this.props * fix(overflow-menu): update snapshots * fix(radio-button): group-level label/button alignment (#2914) Fixes #2286. * Fix sass error (#2905) * chore(deps): bump sshpk in /packages/react/examples/create-react-app (#2915) Bumps [sshpk](https://github.com/joyent/node-sshpk) from 1.13.1 to 1.16.1. - [Release notes](https://github.com/joyent/node-sshpk/releases) - [Commits](TritonDataCenter/node-sshpk@v1.13.1...v1.16.1) * fix(overflow-menu): rollback ul changes * fix(tooltip): set width to content max (#2923) * chore(deps): bump safer-eval (#2930) Bumps [safer-eval](https://github.com/commenthol/safer-eval) from 1.2.3 to 1.3.3. - [Release notes](https://github.com/commenthol/safer-eval/releases) - [Commits](commenthol/safer-eval@v1.2.3...v1.3.3) Signed-off-by: dependabot[bot] <support@github.com> * chore(deps): bump safer-eval in /packages/colors/examples/preview (#2931) Bumps [safer-eval](https://github.com/commenthol/safer-eval) from 1.2.3 to 1.3.3. - [Release notes](https://github.com/commenthol/safer-eval/releases) - [Commits](commenthol/safer-eval@v1.2.3...v1.3.3) Signed-off-by: dependabot[bot] <support@github.com> * fix(button): require iconDescription for icon-only (#2929) * fix(Button): require iconDescription for icon-only Fixes #2884. * chore(test): update snapshots * fix(overflow-menu): update snapshots * Revert "fix(overflow-menu): update snapshots" This reverts commit 1015db6. * fix(overflow-menu): update snapshots * `Revert "fix(overflow-menu): update snapshots" This reverts commit 6fe35a6. * fix(overflow-menu): update snapshots * chore(react): remove redundant version field
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
Jun 12, 2019
…arbon-design-system#2906) * fix(overflow-menu): updated aria-label and roles, made ul a sibling * fix(overflow-menu): removing unused var * fix(overflow-menu): update snapshots * chore(project): use yarn policies to set version to 1.16.0 (carbon-design-system#2902) * chore(project): use yarn policies to set version to 1.16.0 * chore(project): update prettier to ignore .yarn folder * fix(modal): support different numbers of buttons (carbon-design-system#2900) Fixes carbon-design-system#2325. * chore(examples): build examples based on whitelist (carbon-design-system#2903) * chore(release): v10.3.0-rc.2 (carbon-design-system#2908) * fix(overflow-menu): update defaultprops for Menu * fix(overflow-menu): removed add'l this.props * fix(overflow-menu): update snapshots * fix(radio-button): group-level label/button alignment (carbon-design-system#2914) Fixes carbon-design-system#2286. * Fix sass error (carbon-design-system#2905) * chore(deps): bump sshpk in /packages/react/examples/create-react-app (carbon-design-system#2915) Bumps [sshpk](https://github.com/joyent/node-sshpk) from 1.13.1 to 1.16.1. - [Release notes](https://github.com/joyent/node-sshpk/releases) - [Commits](TritonDataCenter/node-sshpk@v1.13.1...v1.16.1) * fix(overflow-menu): rollback ul changes * fix(tooltip): set width to content max (carbon-design-system#2923) * chore(deps): bump safer-eval (carbon-design-system#2930) Bumps [safer-eval](https://github.com/commenthol/safer-eval) from 1.2.3 to 1.3.3. - [Release notes](https://github.com/commenthol/safer-eval/releases) - [Commits](commenthol/safer-eval@v1.2.3...v1.3.3) Signed-off-by: dependabot[bot] <support@github.com> * chore(deps): bump safer-eval in /packages/colors/examples/preview (carbon-design-system#2931) Bumps [safer-eval](https://github.com/commenthol/safer-eval) from 1.2.3 to 1.3.3. - [Release notes](https://github.com/commenthol/safer-eval/releases) - [Commits](commenthol/safer-eval@v1.2.3...v1.3.3) Signed-off-by: dependabot[bot] <support@github.com> * fix(button): require iconDescription for icon-only (carbon-design-system#2929) * fix(Button): require iconDescription for icon-only Fixes carbon-design-system#2884. * chore(test): update snapshots * fix(overflow-menu): update snapshots * Revert "fix(overflow-menu): update snapshots" This reverts commit 1015db6. * fix(overflow-menu): update snapshots * `Revert "fix(overflow-menu): update snapshots" This reverts commit 6fe35a6. * fix(overflow-menu): update snapshots * chore(react): remove redundant version field
emyarod
pushed a commit
to emyarod/carbon
that referenced
this pull request
Jun 18, 2019
…arbon-design-system#2906) * fix(overflow-menu): updated aria-label and roles, made ul a sibling * fix(overflow-menu): removing unused var * fix(overflow-menu): update snapshots * chore(project): use yarn policies to set version to 1.16.0 (carbon-design-system#2902) * chore(project): use yarn policies to set version to 1.16.0 * chore(project): update prettier to ignore .yarn folder * fix(modal): support different numbers of buttons (carbon-design-system#2900) Fixes carbon-design-system#2325. * chore(examples): build examples based on whitelist (carbon-design-system#2903) * chore(release): v10.3.0-rc.2 (carbon-design-system#2908) * fix(overflow-menu): update defaultprops for Menu * fix(overflow-menu): removed add'l this.props * fix(overflow-menu): update snapshots * fix(radio-button): group-level label/button alignment (carbon-design-system#2914) Fixes carbon-design-system#2286. * Fix sass error (carbon-design-system#2905) * chore(deps): bump sshpk in /packages/react/examples/create-react-app (carbon-design-system#2915) Bumps [sshpk](https://github.com/joyent/node-sshpk) from 1.13.1 to 1.16.1. - [Release notes](https://github.com/joyent/node-sshpk/releases) - [Commits](TritonDataCenter/node-sshpk@v1.13.1...v1.16.1) * fix(overflow-menu): rollback ul changes * fix(tooltip): set width to content max (carbon-design-system#2923) * chore(deps): bump safer-eval (carbon-design-system#2930) Bumps [safer-eval](https://github.com/commenthol/safer-eval) from 1.2.3 to 1.3.3. - [Release notes](https://github.com/commenthol/safer-eval/releases) - [Commits](commenthol/safer-eval@v1.2.3...v1.3.3) Signed-off-by: dependabot[bot] <support@github.com> * chore(deps): bump safer-eval in /packages/colors/examples/preview (carbon-design-system#2931) Bumps [safer-eval](https://github.com/commenthol/safer-eval) from 1.2.3 to 1.3.3. - [Release notes](https://github.com/commenthol/safer-eval/releases) - [Commits](commenthol/safer-eval@v1.2.3...v1.3.3) Signed-off-by: dependabot[bot] <support@github.com> * fix(button): require iconDescription for icon-only (carbon-design-system#2929) * fix(Button): require iconDescription for icon-only Fixes carbon-design-system#2884. * chore(test): update snapshots * fix(overflow-menu): update snapshots * Revert "fix(overflow-menu): update snapshots" This reverts commit 1015db6. * fix(overflow-menu): update snapshots * `Revert "fix(overflow-menu): update snapshots" This reverts commit 6fe35a6. * fix(overflow-menu): update snapshots * chore(react): remove redundant version field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2884.
Changelog
Changed
<Button>to ensure its check foriconDescription's existence only happens if the button is icon-only.Removed
iconDescription.Testing / Reviewing
Testing should make sure our React
<Button>is not broken.