-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Toolbar/ToobarSearch): add component name to deprecation warning #4229
chore(Toolbar/ToobarSearch): add component name to deprecation warning #4229
Conversation
Deploy preview for carbon-elements ready! Built with commit de06fc0 |
Deploy preview for the-carbon-components ready! Built with commit de06fc0 https://deploy-preview-4229--the-carbon-components.netlify.com |
Deploy preview for carbon-components-react ready! Built with commit de06fc0 https://deploy-preview-4229--carbon-components-react.netlify.com |
@aagonzales for context, I was wondering if this component was supposed to be in our v10 release, or not. Specifically: http://react.carbondesignsystem.com/?path=/story/toolbar--default This PR is to address deprecating it as we assumed it wasn't supposed to be in this release. |
@dakahn should we also list this component as deprecated in our storybook? |
@aagonzales confirmed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we also update the story to include [Deprecated] Toolbar
?
fyi @tay1orjones |
For reference later -- we first attempted to use the built in Storybook decorators in the title of Toolbar story like But that stuck all the other components into an "Other" category which is weird and not really what we want here. If we ever have multiple deprecated components we could think about prepending each components story like |
…arbon-design-system#4229) * chore(Toolbar/ToobarSearch): add component name to deprecation warning * docs(Toolbar): add deprecation decorator to Toolbar story * docs(Toolbar): un-add deprecation decorator
* feat(search): add styles for 40px search input * chore(react): add component name to deprecation warning for toolbar (#4229) * chore(Toolbar/ToobarSearch): add component name to deprecation warning * docs(Toolbar): add deprecation decorator to Toolbar story * docs(Toolbar): un-add deprecation decorator * feat(search): add medium configuration * feat(search): add medium description to README * feat(search): add clear icon for medium size
We didn't have the component name in our deprecation warning. 🤦♂
This also adds a deprecation warning to the Story. 👍