-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Search): introduce large search back #4238
Conversation
Deploy preview for the-carbon-components ready! Built with commit aa9c3c2 https://deploy-preview-4238--the-carbon-components.netlify.com |
Deploy preview for carbon-components-react ready! Built with commit aa9c3c2 https://deploy-preview-4238--carbon-components-react.netlify.com |
Deploy preview for carbon-elements ready! Built with commit aa9c3c2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me now that #4237 is merged in, pending design approval
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@laurenmrice Good catch - Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Vanilla it still needs to come over one to the left, its slightly off. Then we should be good. I couldn't review React yet because the build failed.
@laurenmrice Is it about the position of X icon, or something else...? Thanks! |
@asudoh Yes sorry, the x icon needs to come over a pixel to the left, its still not in the center. |
No worries @laurenmrice, thank you for clarifying - Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good ! thank you 🙌
Refs #3457.
The styling code is covered by: #4237
Changelog
New
lg
search variant (back).size
prop which takesxl
,lg
, orsm
.Changed
small
prop for the sake ofsize
.Testing / Reviewing
Testing should make sure
<Search>
and<TableToolbarSearch>
are not broken.