Fix(HeaderMenu + HeaderNavigation): handle null item #4682
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4261
Allows
<HeaderMenu>
and<HeaderNavigation>
to handle a null item/child on render.Changelog
Changed
Testing / Reviewing
In
packages/react/src/components/UIShell/UIShell-story.js
pass a null<HeaderMenuItem>
to a<HeaderNavigation>
and<HeaderMenu>
component.ie change:
line 158 to
{false && <HeaderMenuItem href="#">Link 1</HeaderMenuItem>}
line 162 to
{false &&<HeaderMenuItem href="#">Sub-link 1</HeaderMenuItem>}
Link 1 should no longer be visible in the header, and sub-link 1 should disappear from the link 4 dropdown.