fix(devenv): use content margin style for expanded side nav #4886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change ensures that the fixed side nav stories make use of `margin-left` style for `.bx--content` with `.bx--side-nav--expanded` instead of using responsive left margin `v10` grid defines, so that the main content won't be hidden underneath the fixed side nav when fixed it's expanded. Fixes carbon-design-system#3591.
|
Deploy preview for the-carbon-components ready! Built with commit 2562ab0 https://deploy-preview-4886--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react failed. Built with commit 2562ab0 https://app.netlify.com/sites/carbon-components-react/deploys/5df8174c3e24b10008227d90 |
|
Deploy preview for carbon-elements ready! Built with commit 2562ab0 |
joshblack
approved these changes
Dec 16, 2019
abbeyhrt
approved these changes
Dec 16, 2019
asudoh
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
Jan 6, 2020
…esign-system#4886) This change ensures that the fixed side nav stories make use of `margin-left` style for `.bx--content` with `.bx--side-nav--expanded` instead of using responsive left margin `v10` grid defines, so that the main content won't be hidden underneath the fixed side nav when fixed it's expanded. Fixes carbon-design-system#3591.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that the fixed side nav stories make use of
margin-leftstyle for.bx--contentwith.bx--side-nav--expandedinstead of using responsive left marginv10grid defines, so that the main content won't be hidden underneath the fixed side nav when it's expanded.Fixes #3591.
Changelog
Changed
Testing / Reviewing
Testing should make sure UI shell stories are not broken.