fix(ComboBox): ensure unique keys #4999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change swiches React `key`s of the items of `<Dropdown>` as well as the one of `<ComboBox>` from their text content to provided keys in data. This is applying the corresponding logic of `<MultiSelect>`. In this way duplicate item text won't yeild duplicate React keys. Fixes carbon-design-system#4969.
|
Deploy preview for the-carbon-components ready! Built with commit 0a657cd https://deploy-preview-4999--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 0a657cd |
|
Deploy preview for carbon-components-react ready! Built with commit 0a657cd https://deploy-preview-4999--carbon-components-react.netlify.com |
emyarod
approved these changes
Jan 10, 2020
joshblack
approved these changes
Jan 10, 2020
joshblack
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change switches React
keys of the items of<Dropdown>as well as the one of<ComboBox>from their text content to provided keys in data.This is applying the corresponding logic of
<MultiSelect>.In this way duplicate item text won't yeild duplicate React keys.
Fixes #4969.
Changelog
Changed
<Dropdown>as well as the one of<ComboBox>from their text content to provided keys in data.Testing / Reviewing
Testing should make sure
<Dropdown>and<ComboBox>are not broken.