Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(uishell): close HeaderMenu on blur #5003

Merged
merged 8 commits into from
Jan 13, 2020
Merged

fix(uishell): close HeaderMenu on blur #5003

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
771f132
fix(uishell): close HeaderMenu on blur
Jan 10, 2020
495b71b
Merge branch 'master' into bug/4930
GregDevProjects Jan 11, 2020
dc183a9
Merge branch 'master' into bug/4930
tw15egan Jan 13, 2020
86a84a2
fix(uishell): check for sub menu item on blur
Jan 13, 2020
9acf262
Merge branch 'bug/4930' of github.com:GregDevProjects/carbon into bug…
Jan 13, 2020
c2567df
Merge branch 'master' into bug/4930
GregDevProjects Jan 13, 2020
0a43358
Merge branch 'master' into bug/4930
tw15egan Jan 13, 2020
4ef5aa9
Merge branch 'master' into bug/4930
asudoh Jan 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions packages/react/src/components/UIShell/HeaderMenu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,18 @@ class HeaderMenu extends React.Component {
handleOnBlur = event => {
// Rough guess for a blur event that is triggered outside of our menu or
// menubar context
if (!event.relatedTarget) {
this.setState({ expanded: false, selectedIndex: null });
const itemTriggeredBlur = this.items.find(
element => element === event.relatedTarget
);

if (
event.relatedTarget &&
(event.relatedTarget.getAttribute('href') !== '#' || itemTriggeredBlur)
) {
return;
}

this.setState({ expanded: false, selectedIndex: null });
};

/**
Expand Down