fix(data-table-skeleton): remove unnecessary border bottom #5040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit b9fc8c5 |
|
Deploy preview for the-carbon-components ready! Built with commit b9fc8c5 https://deploy-preview-5040--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react ready! Built with commit b9fc8c5 https://deploy-preview-5040--carbon-components-react.netlify.com |
asudoh
requested review from
a team and
jeanservaas
and removed request for
a team
abbeyhrt
requested review from
a team and
aagonzales
and removed request for
jeanservaas and
a team
|
@aagonzales for context, the only change here is that the blue border bottom that is on the DataTableSkeleton has been removed. I think we just need you to confirm that is what we want! Let me know if you have any questions |
aagonzales
approved these changes
Jan 15, 2020
|
Thank you @abbeyhrt this border has always mystified me 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2957
This PR removes the
border-bottomon the table header of the DataTable Skeleton, removing the blue line visible here:What it looks like from this PR:
Changelog
Removed
Testing / Reviewing
For designers reviewing: Check the DataTable Skeleton and make sure that the blue border isn't supposed to be there according to spec.