refactor(loading): update from class to function #5054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshblack
approved these changes
Jan 15, 2020
|
Deploy preview for the-carbon-components ready! Built with commit afa0293 https://deploy-preview-5054--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react ready! Built with commit afa0293 https://deploy-preview-5054--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit afa0293 |
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
Jan 23, 2020
This was referenced Feb 25, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To practice refactoring classes to functions, I've updated Loading to a function.
Changelog
Changed
Testing / Reviewing
Make sure Loading still works as expected and there are no console errors