-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(type): update link to type styles in README #5058
Merged
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
ab6ebb7
docs(type): update link to type styles in README
jendowns 5607773
docs(type): update README text for context
jendowns 11ee224
Merge branch 'master' into patch-9
jendowns c6e6ca5
chore: format type package README doc
jendowns 570e54a
Merge branch 'master' into patch-9
jendowns 8bb4891
Merge branch 'master' into patch-9
jendowns 168faa9
Merge branch 'master' into patch-9
jendowns 600a231
Merge branch 'master' into patch-9
emyarod 19dc544
Merge branch 'master' into patch-9
joshblack File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we update the sentence? Could you explain more about the accessibility shortcoming?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I mean to update the sentence completely, to avoid having link text that just says "here"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh sorry just noticed your edit --
Here's two quick resources I found to explain this:
In addition to the reasons about context provided in those links, if you are using a screenreader + tabbing between focusable elements you may just hear "Link Here" or "Link Click here" which isn't helpful.