refactor(notification): refactor component to use hooks #5072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for the-carbon-components ready! Built with commit e7ae306 https://deploy-preview-5072--the-carbon-components.netlify.com |
joshblack
approved these changes
Jan 16, 2020
|
Deploy preview for carbon-components-react failed. Built with commit 2bd9811 https://app.netlify.com/sites/carbon-components-react/deploys/5e20ad6aa8409b0008360c4a |
|
Deploy preview for carbon-elements failed. Built with commit 2bd9811 https://app.netlify.com/sites/carbon-elements/deploys/5e20ad6af04baa0009a5873c |
|
Deploy preview for carbon-elements ready! Built with commit e7ae306 |
|
Deploy preview for carbon-components-react ready! Built with commit e7ae306 https://deploy-preview-5072--carbon-components-react.netlify.com |
tw15egan
approved these changes
Jan 16, 2020
added 2 commits
January 16, 2020 14:38
…bon into notification-hook-refactor
|
@tw15egan done! thanks |
joshblack
pushed a commit
to joshblack/carbon
that referenced
this pull request
Jan 23, 2020
This was referenced Feb 25, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring Notification component to use hooks
Changelog
New
Changed
NotificationIconreturn statementstateTesting / Reviewing
Make sure notification is rendering.