fix(accordion): update accordion breakpoints #5074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for the-carbon-components ready! Built with commit 1c7eb59 https://deploy-preview-5074--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 1c7eb59 |
|
Deploy preview for carbon-components-react ready! Built with commit 1c7eb59 https://deploy-preview-5074--carbon-components-react.netlify.com |
|
Deploy preview for the-carbon-components ready! Built with commit 1462032 https://deploy-preview-5074--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 1462032 |
|
Deploy preview for carbon-components-react failed. Built with commit 1462032 https://app.netlify.com/sites/carbon-components-react/deploys/5e20e7b4f56de30009658613 |
joshblack
approved these changes
Jan 16, 2020
joshblack
reviewed
Jan 16, 2020
tw15egan
force-pushed
the
accordion-padding
branch
from
0313f90
to
bc5084f
Compare
asudoh
added
status: ready to merge 🎉
and removed
status: ready for review 👀
status: visual review 🔍
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4993
Updates Accordion to only use
16pxof padding when the screen is below480pxBased on updated specs found hereChangelog
New
480pxand640pxTesting / Reviewing
See that the Accordion content shifts from
1rempadding, to3rempadding, to25%padding as the screen size increases.